multi: fix loopvar and enhance logging around channel reestablishment #8220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yyforyongyu
added
logging
yyforyongyu
force-pushed
the
enhance-logging-switch
branch
from
7b18870 to
d012578
Compare
ellemouton
reviewed
Nov 24, 2023
channeldb/channel.go
Outdated
Comment on lines
2140
to
2141
| log.Debugf("Skipped htlc due to onion has not "+ | ||
| "matched: id=%v, update=%v incoming=%v", |
There was a problem hiding this comment.
strange wording. Perhaps "Skipped htlc since the onion does not match" or "Skipped htlc due to onion mismatch"?
yyforyongyu
force-pushed
the
enhance-logging-switch
branch
3 times, most recently
from
564310c to
8a601dd
Compare
yyforyongyu
changed the title
ziggie1984
approved these changes
Nov 25, 2023
|
|
||
| // TestExtractPayDescs asserts that `extractPayDescs` can correctly turn a | ||
| // slice of htlcs into two slices of PaymentDescriptors. | ||
| func TestExtractPayDescs(t *testing.T) { |
Crypt-iQ
approved these changes
Nov 27, 2023
channeldb/channel.go
Outdated
| onionHash := sha256.Sum256(htlc.OnionBlob[:]) | ||
| if _, ok := remoteHtlcs[onionHash]; !ok { | ||
| log.Debugf("Skipped htlc due to onion mismatched: "+ |
There was a problem hiding this comment.
do we need these logs now that the issue is fixed? I think the debug logs might get spammier
There was a problem hiding this comment.
yeah downgraded to trace instead
yyforyongyu
force-pushed
the
enhance-logging-switch
branch
from
c804390 to
6b489c0
Compare
Roasbeef
requested changes
Nov 27, 2023
yyforyongyu
force-pushed
the
enhance-logging-switch
branch
from
6b489c0 to
ae705e5
Compare
|
Needs a rebase! (release notes conflict) |
yyforyongyu
force-pushed
the
enhance-logging-switch
branch
from
ae705e5 to
4845b7a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempt to provide more logs so we can find out what's the root cause in #8130