Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

htlcswitch: fuzz onion encoding/decoding #7967

Merged
merged 2 commits into from
Oct 19, 2023

Conversation

morehouse
Copy link
Collaborator

Most of these structs are in the lightning-onion repository, so ideally the fuzz targets would live there. But we don't have the same fuzzing infrastructure set up for that repo, making it simpler to put the targets in lnd and the corpora in lnd-fuzz.

Fuzz tests for:
- HopData
- HopPayload
- OnionPacket
hop.Payload and route.Hop are analogs, with onion payloads encoded from
route.Hops and decoded to hop.Payloads. For checking equality of
encoding/decoding, we implement a helper function to convert
hop.Payloads into route.Hops.
@saubyk saubyk requested a review from Crypt-iQ September 8, 2023 18:24
@yyforyongyu yyforyongyu added P2 should be fixed if one has time fuzzing labels Sep 19, 2023
@saubyk saubyk added this to the v0.18.0 milestone Oct 5, 2023
Copy link
Collaborator

@Crypt-iQ Crypt-iQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@guggero guggero self-requested a review October 11, 2023 16:08
@lightninglabs-deploy
Copy link

@guggero: review reminder

@guggero guggero merged commit e1fb1e4 into lightningnetwork:master Oct 19, 2023
@morehouse morehouse deleted the fuzz_onion branch October 19, 2023 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fuzzing P2 should be fixed if one has time
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

6 participants