multi: fix unit test flakes #7954
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yyforyongyu
force-pushed
the
fix-chainfee-unit-test
branch
from
9fb5b68 to
5d21d06
Compare
guggero
reviewed
Sep 4, 2023
There was a problem hiding this comment.
Great fixes!
It looks like CI also ran into another one-in-however-million chances.
Here's the fix for the aezeed flake:
diff --git a/aezeed/cipherseed_test.go b/aezeed/cipherseed_test.go
index 7547f25e9..12c491966 100644
--- a/aezeed/cipherseed_test.go
+++ b/aezeed/cipherseed_test.go
@@ -533,7 +533,16 @@ func TestDecipherIncorrectMnemonic(t *testing.T) {
// a checksum failure.
swapIndex1 := 9
swapIndex2 := 13
- mnemonic[swapIndex1], mnemonic[swapIndex2] = mnemonic[swapIndex2], mnemonic[swapIndex1]
+ mnemonic[swapIndex1], mnemonic[swapIndex2] =
+ mnemonic[swapIndex2], mnemonic[swapIndex1]
+
+ // If the words happen to be the same by pure chance, we'll try again
+ // with different indexes.
+ if mnemonic[swapIndex1] == mnemonic[swapIndex2] {
+ swapIndex1 = 3
+ mnemonic[swapIndex1], mnemonic[swapIndex2] =
+ mnemonic[swapIndex2], mnemonic[swapIndex1]
+ }
// If we attempt to decrypt now, we should get a checksum failure.
// If we attempt to map back to the original cipher seed now, then we
lnwallet/chainfee/estimator_test.go
Outdated
| err string | ||
| name string | ||
| target uint32 | ||
| apiEst uint32 |
There was a problem hiding this comment.
nit: apiEst is no longer used.
Fix the following uint test flake,
```
--- FAIL: TestHistoricalConfDetailsTxIndex (0.00s)
--- FAIL: TestHistoricalConfDetailsTxIndex/rpc_polling_enabled (1.16s)
bitcoind_test.go:174: should have found the transaction within the mempool, but did not: TxNotFoundIndex
FAIL
```
When the numTweaks is zero, we should return a nil instead of
initializing an empty map as we'd get the following error,
```
Diff:
--- Expected
+++ Actual
@@ -11007,4 +11007,3 @@
},
- BreachedHtlcTweaks: (contractcourt.htlcTapTweaks) {
- },
+ BreachedHtlcTweaks: (contractcourt.htlcTapTweaks) <nil>,
```
yyforyongyu
force-pushed
the
fix-chainfee-unit-test
branch
from
5d21d06 to
50f2c27
Compare
|
@guggero thanks for the diff! Also interesting to see we hit the lottery here. Now let's see when we hit |
Roasbeef
approved these changes
Sep 5, 2023
|
|
||
| // If the numTweaks happens to be zero, we return a nil to avoid | ||
| // initializing the map. | ||
| if numTweaks == 0 { |
|
Noticed a flake in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix three uint test flakes,