Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ListAliases call #202

Merged
merged 2 commits into from
Nov 14, 2024
Merged

Conversation

GeorgeTsagk
Copy link
Member

Description

This PR exposes LND's ListAliases RPC call as part of the LightningClient interface

@GeorgeTsagk GeorgeTsagk requested a review from guggero November 13, 2024 15:30
@GeorgeTsagk GeorgeTsagk self-assigned this Nov 13, 2024
@guggero
Copy link
Member

guggero commented Nov 13, 2024

Ah, need to add the permissions for /lnrpc.Lightning/ListAliases to the testdata/permissions.json:

        "/lnrpc.Lightning/ListAliases": {
            "permissions": [
                {
                    "entity": "offchain",
                    "action": "read"
                }
            ]
        },

@dstadulis dstadulis requested a review from bhandras November 13, 2024 18:33
Copy link
Member

@bhandras bhandras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@GeorgeTsagk GeorgeTsagk merged commit f422592 into lightninglabs:lnd-18-4 Nov 14, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants