Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add itest coverage for custom channels strict forwarding #875

Conversation

GeorgeTsagk
Copy link
Member

@GeorgeTsagk GeorgeTsagk commented Oct 16, 2024

Description

This PR adds coverage for the strict forwarding behavior of custom channels.

Dependent PRs

go.mod will be updated once the above PRs have been merged, in order to point to them

@GeorgeTsagk GeorgeTsagk self-assigned this Oct 16, 2024
@dstadulis dstadulis added this to the tapd v0.4.2 milestone Oct 16, 2024
@GeorgeTsagk GeorgeTsagk force-pushed the itest-custom-chan-strict-forwarding branch from 18e477c to 3b61fbe Compare October 21, 2024 14:55
@GeorgeTsagk GeorgeTsagk changed the base branch from 0-19-staging to update-to-lnd-18-4 October 21, 2024 14:55
@GeorgeTsagk GeorgeTsagk force-pushed the itest-custom-chan-strict-forwarding branch from 3b61fbe to 427ec24 Compare October 21, 2024 15:13
@guggero guggero force-pushed the update-to-lnd-18-4 branch 6 times, most recently from 41ab740 to d5262c4 Compare October 22, 2024 15:10
Copy link
Member

@guggero guggero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, LGTM apart from some nits.

Not approving yet because of dependencies.

itest/assets_test.go Outdated Show resolved Hide resolved
itest/assets_test.go Outdated Show resolved Hide resolved
itest/assets_test.go Outdated Show resolved Hide resolved
itest/litd_custom_channels_test.go Outdated Show resolved Hide resolved
@GeorgeTsagk GeorgeTsagk force-pushed the itest-custom-chan-strict-forwarding branch 2 times, most recently from 5ac2b77 to df32849 Compare October 24, 2024 10:28
@GeorgeTsagk
Copy link
Member Author

Updated to point to latest state of tapd/lnd branches, before we change their base and things break:

@GeorgeTsagk GeorgeTsagk requested a review from guggero October 24, 2024 10:29
@guggero
Copy link
Member

guggero commented Oct 24, 2024

Removing request for review until dependencies are in.

@guggero guggero removed their request for review October 24, 2024 17:09
@guggero guggero force-pushed the update-to-lnd-18-4 branch 2 times, most recently from a533a9f to 25d64a1 Compare October 30, 2024 08:37
@jharveyb jharveyb self-requested a review October 31, 2024 15:02
@guggero guggero force-pushed the itest-custom-chan-strict-forwarding branch from df32849 to 7177789 Compare October 31, 2024 15:33
@dstadulis dstadulis assigned guggero and unassigned GeorgeTsagk Oct 31, 2024
Copy link

@jharveyb jharveyb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good test!

@guggero guggero force-pushed the update-to-lnd-18-4 branch from 9c10445 to a4d76ed Compare October 31, 2024 16:00
@guggero guggero force-pushed the itest-custom-chan-strict-forwarding branch from 7177789 to 5b1be53 Compare October 31, 2024 16:05
@guggero guggero merged commit 6b38cf0 into lightninglabs:update-to-lnd-18-4 Oct 31, 2024
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

5 participants