slog: structured logging #1
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So that it does not clash with the standard lib's slog package.
Reuse some of the slog.Level types and add a few of our own. Also, move level logic to its own file for readability.
And let subLog implement the methods by calling its existing methods. Note that subLog will not produce structured logs as of this commit. In future, it can be updated to use an slog.Logger and this package can implement a default slog.Handler.
Update the buffer pool to use a concrete type and steel some other updates from the buffer pool used by std lib. Also adds a few useful helpers that we will use later on and also factors out the timestamp writing part from formatHeader since we will use that again later.
Since we will use it later no with a different skip depth.
ellemouton
force-pushed
the
slog
branch
4 times, most recently
from
30a57a4 to
b060cde
Compare
Which is a valid Handler that can be used with the NewSloggger call.
|
cc @yyforyongyu - This is the same as the PR in btclog but just with the module name updated & the travis file removed. I'll open a follow up that adds basic CI for unit tests and that removes the old logger implementation which will address Oli's comment in the other PR. The reason im splitting this into this and a follow up is:
|
This was referenced Sep 23, 2024
Closed
|
closing in favour of a v2 module in the upstream repo |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See the OG PR here: btcsuite#17
all the initial commits are the same. Only addition is the last few commits that just removes the old logger impl & runs unit tests in GH. Also basic Readme updates.