Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blinded pathfinding fuzzing #2366

Conversation

valentinewallace
Copy link
Contributor

Fuzz test blinded payment pathfinding. Partially addresses #1970.

fuzz/src/router.rs Outdated Show resolved Hide resolved
fuzz/src/router.rs Outdated Show resolved Hide resolved
@valentinewallace valentinewallace force-pushed the 2023-05-blinded-pathfinding-fuzz branch from 02bc479 to 851ebf7 Compare July 17, 2023 18:37
@valentinewallace valentinewallace added this to the 0.0.117 milestone Jul 17, 2023
@valentinewallace valentinewallace force-pushed the 2023-05-blinded-pathfinding-fuzz branch from 851ebf7 to e7d5950 Compare July 25, 2023 21:58
@valentinewallace
Copy link
Contributor Author

Rebased to fix CI

@codecov-commenter
Copy link

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.19% 🎉

Comparison is base (685f266) 90.33% compared to head (851ebf7) 90.53%.

❗ Current head 851ebf7 differs from pull request most recent head e7d5950. Consider uploading reports for the commit e7d5950 to get more accurate results

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2366      +/-   ##
==========================================
+ Coverage   90.33%   90.53%   +0.19%     
==========================================
  Files         106      106              
  Lines       55732    57311    +1579     
  Branches    55732    57311    +1579     
==========================================
+ Hits        50347    51886    +1539     
- Misses       5385     5425      +40     
Files Changed Coverage Δ
lightning/src/blinded_path/mod.rs 93.18% <100.00%> (-1.08%) ⬇️
lightning/src/routing/router.rs 93.38% <100.00%> (-0.26%) ⬇️

... and 34 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

For reuse in fuzzing blinded payment pathfinding, and to ensure fuzz input
values are fetched in the same order in both match arms.
Copy link
Collaborator

@TheBlueMatt TheBlueMatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@valentinewallace valentinewallace merged commit 6f58072 into lightningdevkit:main Jul 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants