Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix findRoute segfault #118

Merged

Conversation

arik-so
Copy link
Contributor

@arik-so arik-so commented Sep 13, 2023

No description provided.

@arik-so
Copy link
Contributor Author

arik-so commented Sep 13, 2023

This does introduce 5 new instances of direct leaks in the address sanitizer logs, but I don't know how to fix this differently. Ideas welcome @tnull :)

tnull
tnull previously approved these changes Sep 13, 2023
Copy link
Collaborator

@tnull tnull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Confirmed that test case reproduces the reported failure and is fixed by the given patch.
Unfortunately I don't have a good idea either, but leaking is always preferable over segfaulting...

src/generation/base_type_generator.mts Show resolved Hide resolved
@arik-so arik-so merged commit f300e82 into lightningdevkit:main Sep 13, 2023
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants