Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove opencv dependencies partial #1743

Conversation

vectorvp
Copy link
Contributor

No description provided.

@vectorvp
Copy link
Contributor Author

vectorvp commented Nov 22, 2024

It looks like there is an error in unit tests, which is not shown while testing locally.

@vectorvp
Copy link
Contributor Author

@guarin, do you know what could be the reason?

@guarin
Copy link
Contributor

guarin commented Nov 26, 2024

Not sure, would have to investigate. The error doesn't give a lot details. I restarted the run now to see if it is reproducible.

@vectorvp
Copy link
Contributor Author

@guarin, can I help somehow to resolve this?

@guarin
Copy link
Contributor

guarin commented Nov 28, 2024

I am honestly not sure what the problem is and I sadly don't have time to reproduce it right now. At least in CI it is reproducible so there is something wrong. The only small thing I saw is that the frames_over_videos are in (T, W, H, C) format instead of (T, H, W, C) but this shouldn't trigger the error.

Did you run your local tests with the same Python and Torchvision version as in CI?

Copy link

codecov bot commented Nov 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.22%. Comparing base (87dde05) to head (1c46e33).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1743   +/-   ##
=======================================
  Coverage   85.22%   85.22%           
=======================================
  Files         162      162           
  Lines        6729     6729           
=======================================
  Hits         5735     5735           
  Misses        994      994           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vectorvp
Copy link
Contributor Author

@guarin, I've resolved the issue, please check. The problem was with video format.

Copy link
Contributor

@guarin guarin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking the time and fixing this!

@guarin guarin merged commit 1e7274a into lightly-ai:master Dec 3, 2024
14 checks passed
@vectorvp vectorvp deleted the issue-1477-remove-opencv-dependencies-partial branch December 3, 2024 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants