Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jeremy lig 3948 make ssl docs more distinct #1394

Merged
merged 8 commits into from
Sep 14, 2023

Conversation

japrescott
Copy link
Contributor

@japrescott japrescott commented Sep 13, 2023

closes lig-3948

  • replace logos to highlight we are talking about Lightly SSL and not about "Lightly"
  • replace all self-references to lightly with Lightly SSL or clarify when needed that its Lightly Worker
  • add banner referring to the Lightly Worker docs
  • pimp footer and add link to github and worker docs
Screenshot 2023-09-14 at 13 52 39

-> some formatting seem to be off but most likely due to it locally being built

@codecov
Copy link

codecov bot commented Sep 13, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (3f3714d) 85.41% compared to head (9041384) 85.41%.
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1394   +/-   ##
=======================================
  Coverage   85.41%   85.41%           
=======================================
  Files         130      130           
  Lines        5465     5465           
=======================================
  Hits         4668     4668           
  Misses        797      797           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@michal-lightly michal-lightly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is really great! Left only minor comments.

docs/source/conf.py Outdated Show resolved Hide resolved
docs/source/docker/advanced/datapool.rst Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
docs/source/index.rst Outdated Show resolved Hide resolved
docs/source/index.rst Outdated Show resolved Hide resolved
Jeremy A. Prescott and others added 2 commits September 13, 2023 17:43
Copy link
Contributor

@michal-lightly michal-lightly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

README.md Show resolved Hide resolved
@japrescott japrescott merged commit 100afe6 into master Sep 14, 2023
7 checks passed
@japrescott japrescott deleted the jeremy-lig-3948-make-ssl-docs-more-distinct branch September 14, 2023 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants