Adding unit tests #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Failing because of #80 |
|
Also failing because of #81 |
|
Moved to in progress given issues. Until this PR builds successfully with tests it is not ready. An alternative is to remove the broken tests and add them in the PR that includes the fix for the issues noted above. |
|
@jewzaam I have disabled the unit tests for the time being so that this PR can be accepted. |
|
|
||
| String dialect = p.getStringProperty(node, "dialect"); | ||
| if (dialect == null || dialect.isEmpty()) { | ||
| throw com.redhat.lightblue.util.Error.get(RDBMSConstants.ERR_FIELD_REQUIRED, "No field informed"); |
There was a problem hiding this comment.
Error is very generic, please indicate what is not set. Could say "Missing field 'dialect'" or something.
There was a problem hiding this comment.
Added #83 for this, not going to hold up the PR for this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.