CRUD controller includes documents which failed to update in results #387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 4, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to address on of the problems identified in lightblue-platform/lightblue-core#811
The constraints enforcement is a bit unclear to me.
For inserts and saves, constraints are enforced at the Mediator level. CRUD Controller allows insertion of a document with a null required field (there is even a test for that behavior: MongoCRUDControllerTest.insertTest_nullReqField).
For updates, this is enforced at the controller level, probably because we need a full document to check constraints, so it has to be read first. However, if constraints are not satisfied, crud controller indicates that only by setting the matchCount and modifiedCount fields accordingly. The status of the response is COMPLETE. I think it should be ERROR or PARTIAL and the failed documents should be included in the response, but I'm not sure I understand the intention behind all this.