Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Demonstration Only] Cross-Version Support for Scala 2 and Scala 3 #350

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

[Demonstration Only] Cross-Version Support for Scala 2 and Scala 3 #350

wants to merge 2 commits into from

Commits on Oct 6, 2023

  1. Add support for scala 2/3 compatible macros 

    A lot of things were removed that the original scala-logging repo was leveraging heavily:
- Build/deploy definitions (these can easily be restored)
- LoggerTakingImplicits (couldn't get the version-unifying project to build with implicits being involved in the macros for some reason)
- Scala 2.11 and 2.12 support (cross-version macro support is limited to very specific versions of Scala 2.13 and Scala 3)

This commit represents the beginning of the Lucid Software branch of the scala-logging library. Due to the major changes, it should never be merged back into the scala-logging library, but it can serve as a starting point for those interested in attempting to bridge the compatibility gap between this library and Scala 2 + 3 in a less destructive way.
    @srollins-lucid
    srollins-lucid committed Oct 6, 2023
    Configuration menu
    Copy the full SHA
    a5e76ba View commit details
    Browse the repository at this point in the history

  2. Don't run tests against scala 2.11 or scala 2.12 

    Definitely don't merge this into the upstream repo!
    @srollins-lucid
    srollins-lucid committed Oct 6, 2023
    Configuration menu
    Copy the full SHA
    9752b28 View commit details
    Browse the repository at this point in the history