Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update configuration #405

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 22 additions & 17 deletions .github/pull_request_template.md
Original file line number Diff line number Diff line change
@@ -1,16 +1,16 @@
[Reviewers guide](https://www.notion.so/lightbase/Pull-request-PR-reviews-Frontend-66f65f2fc91948a79d8f53a138e6f422)
**Description**

**Checklist**

Please check the following items before submitting the PR. Add relevant explanations for the below points
under the description.
Please check the following items before submitting the PR. Add relevant explanations for the below points in
the description.

- [ ] The PR title is in line with the following examples:
- `chore(ci): add speedups to lint job`
- `fix(user): always show the email in the profile drop down`
- `feat(tags): add SVG symbols to the tag cards`
- [ ] The PR is implemented according to the Acceptance Criteria. Include a link to the ticket `[XYZ-123]` in
the description.
- [ ] The PR is implemented according to the Acceptance Criteria. Include a link to Jira or Sentry in the
description.
- [ ] The PR includes correct use of semantic HTML, aria attributes, etc. See
[Notion](https://www.notion.so/lightbase/Hulpmiddelen-9e06d0c83147455389843e4a7634f022) for tools that
can help you with this.
Expand All @@ -27,16 +27,21 @@ under the description.
[technical debt](https://www.notion.so/Technical-debt-refactoring-eabbdee2b66945d7b55517f92cca20bb) is
marked with a TODO comment.
- Obsolete comments are removed.
- [ ] The PR does not add a new dependency. Follow
[this document](https://www.notion.so/lightbase/Introducing-dependencies-ac169cfeafb44782bded308810237737)
and add the link to in the description.
- [ ] The PR does not contain changes to the design system.
- [ ] The PR does not add 'exclusions' on the design system.
- [ ] The PR reuses existing components.
- [ ] The PR does not introduce new base components.
- [ ] The PR uses translations for all necessary strings.
- [ ] The PR does not include unrelated changes.
- [ ] The PR does not include `// @ts-expect-error` / `// eslint-disable` comments.
- [ ] The PR does not mix dependency updates and refactoring with features and fixes.

**Description**
<!-- Other information and points to manually check and if necessary, elaborate on in the description

Jira's links are automatically expanded. So you can write `[JIRA-123]`, which a Jira bot will automatically resolve into a valid url after you have updated a PR comment or description.
Sentry links can be easily copied from the Sentry Issue page by clicking the 'chevron-down' icon -> 'Copy markdown link'.

- The PR does not add a new dependency. Follow [this document](https://www.notion.so/lightbase/Introducing-dependencies-ac169cfeafb44782bded308810237737) and add the link to in the description.
- The PR does not contain changes to the design system.
- The PR does not add 'exclusions' on the design system.
- The PR reuses existing components.
- The PR does not introduce new base components.
- The PR uses translations for all necessary strings.
- The PR does not include unrelated changes.
- The PR does not include `// @ts-expect-error` / `// eslint-disable` comments.
- The PR does not mix dependency updates and refactoring with features and fixes.
-->

[Reviewers guide](https://www.notion.so/lightbase/Pull-request-PR-reviews-Frontend-66f65f2fc91948a79d8f53a138e6f422)
Loading