Skip to content

Commit

Permalink
chore(typescript): use total-typescripts' tsconfig package
Browse files Browse the repository at this point in the history
Also drops our own package, since it mostly followed their recommended setup already.

Signed-off-by: Dirk de Visser <[email protected]>
  • Loading branch information
dirkdev98 committed May 14, 2024
1 parent 2c1f0c6 commit f43b333
Show file tree
Hide file tree
Showing 11 changed files with 12 additions and 173 deletions.
6 changes: 5 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,12 +5,16 @@ All public packages & GitHub workflows developed and used by

## Overview

- Various [TSConfigs](./packages/tsconfig) to extend from
- Configurable [ESLint-config](./packages/eslint-config) which includes linting and
formatting
- Various reusable workflows
- [lib-license-checker](./docs/workflows/lib-license-checker.md)

## Recommendations

- Use [Total Typescript's TSConfig](https://github.com/total-typescript/tsconfig) package.
It provides a sensible default TypeScript config for most usecases.

## Contributing

This repository is set up as a monorepo. All individual packages are set up with build,
Expand Down
6 changes: 4 additions & 2 deletions apps/backend/tsconfig.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,9 @@
{
"extends": "@lightbase/tsconfig/node-package.json",
"extends": "@total-typescript/tsconfig/tsc/no-dom/app",
"compilerOptions": {
"outDir": "dist"
"outDir": "dist",
// We transpile this as an app, however, we need composite to run this as part of a top-level build.
"composite": true
},
"include": ["**/*"]
}
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
},
"devDependencies": {
"@lightbase/eslint-config": "0.1.0",
"@lightbase/tsconfig": "0.1.0",
"@total-typescript/tsconfig": "1.0.4",
"patch-package": "8.0.0",
"typescript": "5.5.0-beta"
},
Expand Down
2 changes: 1 addition & 1 deletion packages/eslint-config/tsconfig.json
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"extends": "@lightbase/tsconfig/node-package.json",
"extends": "@total-typescript/tsconfig/tsc/no-dom/library-monorepo",
"compilerOptions": {
"outDir": "dist"
},
Expand Down
21 changes: 0 additions & 21 deletions packages/tsconfig/LICENSE

This file was deleted.

73 changes: 0 additions & 73 deletions packages/tsconfig/README.md

This file was deleted.

3 changes: 0 additions & 3 deletions packages/tsconfig/eslint.config.js

This file was deleted.

24 changes: 0 additions & 24 deletions packages/tsconfig/node-backend.json

This file was deleted.

28 changes: 0 additions & 28 deletions packages/tsconfig/node-package.json

This file was deleted.

18 changes: 0 additions & 18 deletions packages/tsconfig/package.json

This file was deleted.

2 changes: 1 addition & 1 deletion tsconfig.json
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"extends": "@lightbase/tsconfig/node-package.json",
"extends": "@total-typescript/tsconfig/tsc/no-dom/library-monorepo",
"compilerOptions": {
// Only used to check JS files
"noEmit": true,
Expand Down

0 comments on commit f43b333

Please sign in to comment.