Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump tokenfactory to 0.50.5 #109

Merged
merged 1 commit into from
Dec 11, 2024
Merged

Conversation

fmorency
Copy link
Collaborator

@fmorency fmorency commented Dec 11, 2024

TF 0.50.5 allows querying denoms by denom owner.

Summary by CodeRabbit

  • Chores
    • Updated various dependencies to ensure compatibility and address vulnerabilities.
    • Corrected versions for cosmossdk.io/core, github.com/cosmos/cosmos-sdk, and github.com/spf13/viper.
    • Specified exact versions for dependencies in the interchaintest module.

@fmorency fmorency requested a review from jgryffindor December 11, 2024 13:40
@fmorency fmorency self-assigned this Dec 11, 2024
Copy link

coderabbitai bot commented Dec 11, 2024

Walkthrough

The changes involve updates to the go.mod files in two modules: the main module and the interchaintest module. Key modifications include correcting and specifying versions for various dependencies, such as downgrading github.com/spf13/viper and github.com/syndtr/goleveldb, and updating github.com/strangelove-ventures/tokenfactory. Additionally, the cosmossdk.io/core dependency has been replaced with a lower version, and specific forks of the Cosmos SDK are now referenced. These changes aim to ensure compatibility and address issues related to dependency management.

Changes

File Change Summary
go.mod - Updated github.com/strangelove-ventures/tokenfactory from v0.50.4-wasmvm2 to v0.50.5-wasmvm2
- Replaced cosmossdk.io/core from v0.12.0 to v0.11.0
- Redirected github.com/cosmos/cosmos-sdk to github.com/liftedinit/cosmos-sdk at v0.50.8-liftedinit.1
- Downgraded github.com/spf13/viper from v1.19.0 to v1.17.0
- Downgraded github.com/syndtr/goleveldb to v1.0.1-0.20210819022825-2ae1ddf74ef7
interchaintest/go.mod - Updated github.com/strangelove-ventures/tokenfactory from v0.50.4-wasmvm2 to v0.50.5-wasmvm2
- Replaced cosmossdk.io/core with v0.11.0
- Replaced github.com/ChainSafe/go-schnorrkel with two versions: v0.0.0-20200405005733-88cbf1b4c40d and v1.0.0
- Redirected github.com/cosmos/cosmos-sdk to github.com/liftedinit/cosmos-sdk at v0.50.8-liftedinit.1
- Replaced github.com/gogo/protobuf with github.com/regen-network/protobuf v1.3.3-alpha.regen.1

Possibly related PRs

  • chore: bump to go 1.22.7 #96: The changes in the go.mod file for the main PR and this PR both involve updating the Go version to 1.22.7, indicating a direct relationship in terms of dependency management.
  • chore: bump tokenfactory to 0.54.0 #97: Both the main PR and this PR update the version of the github.com/strangelove-ventures/tokenfactory dependency, showing a direct connection in the management of this specific dependency.
  • fix: upgrade fw & vuln #107: This PR also modifies the go.mod file, specifically updating the cosmossdk.io/core and github.com/cosmos/cosmos-sdk dependencies, which are also addressed in the main PR, indicating a related focus on dependency management.

🐰 In the garden, we hop and play,
With dependencies fresh, hip-hip-hooray!
Versions aligned, bugs kept at bay,
In our code, we dance and sway!
With every change, we leap and cheer,
For a stable future, the path is clear! 🌼


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between b2bd373 and aa38b40.

⛔ Files ignored due to path filters (2)
  • go.sum is excluded by !**/*.sum
  • interchaintest/go.sum is excluded by !**/*.sum
📒 Files selected for processing (2)
  • go.mod (1 hunks)
  • interchaintest/go.mod (1 hunks)
🔇 Additional comments (4)
go.mod (2)

Line range hint 15-16: Security fix: Viper downgrade addresses vulnerability

Good catch on downgrading viper to address the GHSA-h395-qcrw-5vmq vulnerability.


50-50: Verify tokenfactory version compatibility

The bump from v0.50.4-wasmvm2 to v0.50.5-wasmvm2 looks good. Let's verify there are no breaking changes.

✅ Verification successful

Tokenfactory upgrade is safe to proceed

The upgrade from v0.50.4-wasmvm2 to v0.50.5-wasmvm2 only adds a new query feature for denoms by admin without any breaking changes to existing interfaces. The changelog confirms this is a backwards-compatible feature addition.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Check for breaking changes in tokenfactory upgrade

# Check the changelog or release notes
gh api repos/strangelove-ventures/tokenfactory/releases/tags/v0.50.5-wasmvm2 --jq .body

# Look for any major interface changes
rg -A 5 "type.*interface" 

Length of output: 5581

interchaintest/go.mod (2)

28-28: LGTM: Version consistency maintained

The tokenfactory version bump to v0.50.5-wasmvm2 is consistent with the root go.mod file.


Line range hint 8-11: Well-documented compatibility fixes

Good documentation explaining the ChainSafe/go-schnorrkel version requirements for Cosmos compatibility.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Experiment)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

codecov bot commented Dec 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.96%. Comparing base (b2bd373) to head (aa38b40).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #109   +/-   ##
=======================================
  Coverage   77.96%   77.96%           
=======================================
  Files          33       33           
  Lines        2187     2187           
=======================================
  Hits         1705     1705           
  Misses        395      395           
  Partials       87       87           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fmorency fmorency merged commit df64d9f into liftedinit:main Dec 11, 2024
16 checks passed
@fmorency fmorency deleted the bump-tf-0505 branch December 11, 2024 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant