Merge initial ram synchronization work #3
Conversation
…t messages from the server
# Conflicts: # games/superopti.py
brains/andalite.py
Outdated
| self.receiveBytes() | ||
| return Sapiens.Step(self) | ||
|
|
||
| def Event(self, evt): |
There was a problem hiding this comment.
are Event, Path, Victory necessary here? (in fact, pretty sure Victory's gone from the base class)
There was a problem hiding this comment.
nope i'll clean 'em up
brains/andalite.py
Outdated
| thread.daemon = True | ||
| thread.start() | ||
| #asyncio.get_event_loop().run_forever() | ||
| def threadMain(self): |
There was a problem hiding this comment.
(PEP8) style nit: i think this method needs one more \n before it and one fewer \n after it
There was a problem hiding this comment.
also it looks like all the new methods are lowerCamel while the existing stuff is UpperCamel and the PEP8 standard (as well as that of the libretro C API) is snake_case. we should probably standardize on one style... can be decided later and done in a different commit tho
There was a problem hiding this comment.
agreed. let's snap to snake_case since that's more pythonic
brains/andalite.py
Outdated
|
|
||
|
|
||
| async def handleSocket(self): | ||
| async with websockets.connect('ws://localhost:8765') as websocket: |
There was a problem hiding this comment.
we should probably make the address be a parameter given to the brain (with this as the default)
There was a problem hiding this comment.
hard to do this with the way args are parsed... created #6 to track
| async def messageConsumer(self, websocket): | ||
| while True: | ||
| message = await websocket.recv() | ||
| data = ast.literal_eval(message) |
There was a problem hiding this comment.
this'll do for now, but we may want to think about a different wire format than hoping eval(str(x)) remains an identity function for all the types.
There was a problem hiding this comment.
agreed. this is also pretty inefficient tbh
brains/andalite.py
Outdated
| return Sapiens.Victory(self) | ||
|
|
||
| def sendMemory(self): | ||
| self.sendNewBytes(0xcc24, 11) # menu data |
brains/andalite.py
Outdated
| if lastData == None or start != None and lastData.get('data') != data.get('data'): | ||
| print("writing data") | ||
| self.game.PokeMemoryRegion(data['offset'], data['data']) | ||
| self.lastSent['offset'] = data |
There was a problem hiding this comment.
should this be self.lastSent[start]
No description provided.