feat(@clayui/css): LPD-40160 Adds menubar-primary for CMS Product Menu variant #5898
+395
−46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… for CMS Product Menu variant
…enu in VerticalNav
|
@marcoscv-work any recommendations for this one? |
|
Hey guys @ethib137 @pat270 if we use |
Comment on lines
+279
to
+300
| <Nav aria-orientation="vertical" nested role="menubar"> | ||
| <VerticalNavContext.Provider | ||
| value={{ | ||
| activeKey: | ||
| active && collection.hasItem(active) | ||
| ? active | ||
| : hasDepthActive | ||
| ? null | ||
| : undefined, | ||
| ariaCurrent: ariaCurrent ? 'page' : null, | ||
| childrenRoot: childrenRootRef, | ||
| close, | ||
| expandedKeys, | ||
| firstKey: collection.getFirstItem().key, | ||
| open, | ||
| spritemap, | ||
| toggle, | ||
| }} | ||
| > | ||
| <Collection<T> collection={collection} /> | ||
| </VerticalNavContext.Provider> | ||
| </Nav> |
There was a problem hiding this comment.
You could store this in a constant to avoid repeating the code and reuse it below.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://liferay.atlassian.net/browse/LPD-40160
I'm sending this as a draft because we have a problem with the accordion headers. They can only be
buttonand in some of the headers we have nested plus buttons. Having abuttonnested in abuttonviolates:from the w3c spec. I need some help figuring out which component we should place
<div role="button">to make our markup valid.