Login Screen Work #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ded at this time. Make the core project scheme shared.
PerrigoGames
requested changes
Jan 21, 2020
| } | ||
|
|
||
| if(notification.name == LoginViewController.userNameNotification) { | ||
| self.userName = notification.userInfo!["userName"] as! String |
There was a problem hiding this comment.
If this map returns null when you ask for a String key, then I'd suggest combining these notifications into a single notification and checking all of the possible keys any time something changes.
There was a problem hiding this comment.
In Kotlin, we can do a thing like:
(notification.userInfo!["userName"] as? String)?.let { userName = it }
This basically:
- queries the map for the specified key, then attempts to convert that to a string
- if the end result of that is not null, then enter the block, setting an implicit variable
itto the converted string - the block sets the local userName variable
| self.twitterName = notification.userInfo!["twitterName"] as! String | ||
| } | ||
|
|
||
| // Remove when comfortable with functionality |
There was a problem hiding this comment.
Suggested change
| // Remove when comfortable with functionality | |
| // FIXME Remove when comfortable with functionality |
This makes finding debug-only code more searchable.
|
|
||
| if(notification.name == LoginViewController.userNameNotification) { | ||
| self.userName = notification.userInfo!["userName"] as! String | ||
| if (self.userName != "") { |
There was a problem hiding this comment.
Suggested change
| if (self.userName != "") { | |
| signInButton.isEnabled = self.userName != "" |
| if(notification.name == LoginViewController.userNameNotification) { | ||
| self.userName = notification.userInfo!["userName"] as! String | ||
| if (self.userName != "") { | ||
| signInButton.isEnabled = true |
There was a problem hiding this comment.
Suggested change
| signInButton.isEnabled = true |
| self.userName = notification.userInfo!["userName"] as! String | ||
| if (self.userName != "") { | ||
| signInButton.isEnabled = true | ||
| } else { |
There was a problem hiding this comment.
Suggested change
| } else { |
| if (self.userName != "") { | ||
| signInButton.isEnabled = true | ||
| } else { | ||
| signInButton.isEnabled = false |
There was a problem hiding this comment.
Suggested change
| signInButton.isEnabled = false |
| signInButton.isEnabled = true | ||
| } else { | ||
| signInButton.isEnabled = false | ||
| } |
There was a problem hiding this comment.
Suggested change
| } |
God this feature sucks.
| @@ -11,16 +11,66 @@ | |||
| import UIKit | |||
|
|
|||
| class LoginViewController: UIViewController { | |||
|
|
|||
| static let userNameNotification = Notification.Name("userNameNotification") | |||
There was a problem hiding this comment.
We really just need one of these. Call it loginInfoNotification
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to make the login screen more interactable.
Still need to save player info state, but keeping this small to get this screen moving.