Merge pull request square#102 from square/nits

Address review feedback nits

Gemfile.lock

@@ -39,7 +39,7 @@ GIT
 PATH
   remote: .
   specs:
-    cocoapods-generate (2.1.0)
+    cocoapods-generate (2.1.1)
       cocoapods-disable-podfile-validations (~> 0.1.1)
 
 GEM

VERSION

@@ -1 +1 @@
-2.1.0
+2.1.1

lib/cocoapods/generate/installer.rb

@@ -410,7 +410,7 @@ def create_main_source_file(project, pod_targets, name)
         source_file.open('w') do |f|
           f << import_statements.join("\n")
           f << "\n" unless import_statements.empty?
-          f << "int main() {}\n"
+          f << "int main() { return 0; }\n"
         end
 
         source_file

lib/cocoapods/generate/podfile_generator.rb

@@ -82,7 +82,7 @@ def podfile_for_specs(specs)
             end
             pods_for_transitive_dependencies.uniq!
 
-            spec_names = specs.map { |s| s.root.name }
+            spec_names = specs.map { |s| s.root.name }.to_set
             dependencies = generator
                            .transitive_dependencies_by_pod
                            .values_at(*pods_for_transitive_dependencies)

spec/integration/fork/after/gen/Foo/App-iOS/main.m

@@ -1,2 +1,2 @@
 @import Foo;
-int main() {}
+int main() { return 0; }

spec/integration/fork/after/gen/Foo/App-macOS/main.m

@@ -1,2 +1,2 @@
 @import Foo;
-int main() {}
+int main() { return 0; }

spec/integration/fork/after/gen/Foo/App-tvOS/main.m

@@ -1,2 +1,2 @@
 @import Foo;
-int main() {}
+int main() { return 0; }

spec/integration/fork/after/gen/Foo/App-watchOS/main.m

@@ -1,2 +1,2 @@
 @import Foo;
-int main() {}
+int main() { return 0; }

spec/integration/local-version-of-published-podspec/after/gen/Foo/App-iOS/main.m

@@ -1 +1 @@
-int main() {}
+int main() { return 0; }

spec/integration/local-version-of-published-podspec/after/gen/Foo/App-macOS/main.m

@@ -1 +1 @@
-int main() {}
+int main() { return 0; }

spec/integration/local-version-of-published-podspec/after/gen/Foo/App-tvOS/main.m

@@ -1 +1 @@
-int main() {}
+int main() { return 0; }

spec/integration/local-version-of-published-podspec/after/gen/Foo/App-watchOS/main.m

@@ -1 +1 @@
-int main() {}
+int main() { return 0; }

spec/integration/local-version-of-published-podspec/after/gen/Forkable/App-iOS/main.m

@@ -1,2 +1,2 @@
 @import Forkable;
-int main() {}
+int main() { return 0; }

spec/integration/local-version-of-published-podspec/after/gen/Forkable/App-macOS/main.m

@@ -1,2 +1,2 @@
 @import Forkable;
-int main() {}
+int main() { return 0; }

spec/integration/local-version-of-published-podspec/after/gen/Forkable/App-tvOS/main.m

@@ -1,2 +1,2 @@
 @import Forkable;
-int main() {}
+int main() { return 0; }

spec/integration/local-version-of-published-podspec/after/gen/Forkable/App-watchOS/main.m

@@ -1,2 +1,2 @@
 @import Forkable;
-int main() {}
+int main() { return 0; }

spec/integration/local_sources/after/gen/E/App-iOS/main.m

@@ -1,2 +1,2 @@
 @import E;
-int main() {}
+int main() { return 0; }

spec/integration/local_sources/after/gen/E/App-macOS/main.m

@@ -1,2 +1,2 @@
 @import E;
-int main() {}
+int main() { return 0; }

spec/integration/local_sources/after/gen/E/App-tvOS/main.m

@@ -1,2 +1,2 @@
 @import E;
-int main() {}
+int main() { return 0; }

spec/integration/local_sources/after/gen/E/App-watchOS/main.m

@@ -1,2 +1,2 @@
 @import E;
-int main() {}
+int main() { return 0; }

spec/integration/monorepo/after/gen/A/App-iOS/main.m

@@ -1,2 +1,2 @@
 @import A;
-int main() {}
+int main() { return 0; }

spec/integration/monorepo/after/gen/A/App-macOS/main.m

@@ -1,2 +1,2 @@
 @import A;
-int main() {}
+int main() { return 0; }

spec/integration/monorepo/after/gen/A/App-tvOS/main.m

@@ -1,2 +1,2 @@
 @import A;
-int main() {}
+int main() { return 0; }

spec/integration/monorepo/after/gen/A/App-watchOS/main.m

@@ -1,2 +1,2 @@
 @import A;
-int main() {}
+int main() { return 0; }

spec/integration/monorepo/after/gen/B/App-iOS/main.m

@@ -1,2 +1,2 @@
 @import B;
-int main() {}
+int main() { return 0; }

spec/integration/monorepo/after/gen/B/App-macOS/main.m

@@ -1,2 +1,2 @@
 @import B;
-int main() {}
+int main() { return 0; }

spec/integration/monorepo/after/gen/B/App-tvOS/main.m

@@ -1,2 +1,2 @@
 @import B;
-int main() {}
+int main() { return 0; }

spec/integration/monorepo/after/gen/B/App-watchOS/main.m

@@ -1,2 +1,2 @@
 @import B;
-int main() {}
+int main() { return 0; }

spec/integration/monorepo/after/gen/C/App-iOS/main.m

@@ -1,2 +1,2 @@
 @import C;
-int main() {}
+int main() { return 0; }

spec/integration/monorepo/after/gen/C/App-macOS/main.m

@@ -1,2 +1,2 @@
 @import C;
-int main() {}
+int main() { return 0; }

spec/integration/monorepo/after/gen/C/App-tvOS/main.m

@@ -1,2 +1,2 @@
 @import C;
-int main() {}
+int main() { return 0; }

spec/integration/monorepo/after/gen/C/App-watchOS/main.m

@@ -1,2 +1,2 @@
 @import C;
-int main() {}
+int main() { return 0; }

spec/integration/monorepo/after/gen/D/App-iOS/main.m

@@ -1,2 +1,2 @@
 @import D;
-int main() {}
+int main() { return 0; }

spec/integration/monorepo/after/gen/D/App-macOS/main.m

@@ -1,2 +1,2 @@
 @import D;
-int main() {}
+int main() { return 0; }

spec/integration/monorepo/after/gen/D/App-tvOS/main.m

@@ -1,2 +1,2 @@
 @import D;
-int main() {}
+int main() { return 0; }

spec/integration/monorepo/after/gen/D/App-watchOS/main.m

@@ -1,2 +1,2 @@
 @import D;
-int main() {}
+int main() { return 0; }

spec/integration/monorepo/after/gen/E/App-iOS/main.m

@@ -1,2 +1,2 @@
 @import E;
-int main() {}
+int main() { return 0; }

spec/integration/monorepo/after/gen/E/App-macOS/main.m

@@ -1,2 +1,2 @@
 @import E;
-int main() {}
+int main() { return 0; }

spec/integration/monorepo/after/gen/E/App-tvOS/main.m

@@ -1,2 +1,2 @@
 @import E;
-int main() {}
+int main() { return 0; }

spec/integration/monorepo/after/gen/E/App-watchOS/main.m

@@ -1,2 +1,2 @@
 @import E;
-int main() {}
+int main() { return 0; }

spec/integration/monorepo/after/gen/F/App-iOS/main.m

@@ -1,2 +1,2 @@
 @import F;
-int main() {}
+int main() { return 0; }

spec/integration/monorepo/after/gen/F/App-macOS/main.m

@@ -1,2 +1,2 @@
 @import F;
-int main() {}
+int main() { return 0; }

spec/integration/monorepo/after/gen/F/App-tvOS/main.m

@@ -1,2 +1,2 @@
 @import F;
-int main() {}
+int main() { return 0; }

spec/integration/monorepo/after/gen/F/App-watchOS/main.m

@@ -1,2 +1,2 @@
 @import F;
-int main() {}
+int main() { return 0; }

spec/integration/monorepo/after/gen/G/App-iOS/main.m

@@ -1,2 +1,2 @@
 @import G;
-int main() {}
+int main() { return 0; }

spec/integration/monorepo/after/gen/G/App-macOS/main.m

@@ -1,2 +1,2 @@
 @import G;
-int main() {}
+int main() { return 0; }

spec/integration/monorepo/after/gen/G/App-tvOS/main.m

@@ -1,2 +1,2 @@
 @import G;
-int main() {}
+int main() { return 0; }

spec/integration/monorepo/after/gen/G/App-watchOS/main.m

@@ -1,2 +1,2 @@
 @import G;
-int main() {}
+int main() { return 0; }

spec/integration/single_podspec/after/gen/Foo/App-iOS/main.m

@@ -1,2 +1,2 @@
 @import Foo;
-int main() {}
+int main() { return 0; }

spec/integration/single_podspec/after/gen/Foo/App-macOS/main.m

@@ -1,2 +1,2 @@
 @import Foo;
-int main() {}
+int main() { return 0; }

spec/integration/single_podspec/after/gen/Foo/App-tvOS/main.m

@@ -1,2 +1,2 @@
 @import Foo;
-int main() {}
+int main() { return 0; }

spec/integration/single_podspec/after/gen/Foo/App-watchOS/main.m

@@ -1,2 +1,2 @@
 @import Foo;
-int main() {}
+int main() { return 0; }

spec/integration/single_workspace/after/gen/Workspace/App-iOS/main.m

@@ -5,4 +5,4 @@
 @import E;
 @import F;
 @import G;
-int main() {}
+int main() { return 0; }

spec/integration/single_workspace/after/gen/Workspace/App-macOS/main.m

@@ -5,4 +5,4 @@
 @import E;
 @import F;
 @import G;
-int main() {}
+int main() { return 0; }

spec/integration/single_workspace/after/gen/Workspace/App-tvOS/main.m

@@ -5,4 +5,4 @@
 @import E;
 @import F;
 @import G;
-int main() {}
+int main() { return 0; }

spec/integration/single_workspace/after/gen/Workspace/App-watchOS/main.m

@@ -5,4 +5,4 @@
 @import E;
 @import F;
 @import G;
-int main() {}
+int main() { return 0; }

spec/integration/use_libraries/after/gen/Foo/App-iOS/main.m

@@ -1 +1 @@
-int main() {}
+int main() { return 0; }

spec/integration/use_libraries/after/gen/Foo/App-macOS/main.m

@@ -1 +1 @@
-int main() {}
+int main() { return 0; }

spec/integration/use_libraries/after/gen/Foo/App-tvOS/main.m

@@ -1 +1 @@
-int main() {}
+int main() { return 0; }

spec/integration/use_libraries/after/gen/Foo/App-watchOS/main.m

@@ -1 +1 @@
-int main() {}
+int main() { return 0; }