More progress on broadcast feature #944

julien4215 · 2024-08-26T11:50:47Z

screen-20240910-235044.2.mp4

ijm8710 · 2024-08-26T16:57:38Z

It's minor but not sure tournament is the right word to switch between open and gm specific.
Maybe draw. Veloce may know the best word but I think tournament may falsely induce the user to think that's a dropdown to switch to a whole new tournament altogether when it's not.

ornicar · 2024-08-26T19:49:26Z

Very impressive work Julien! 👍

tom-anders · 2024-08-27T15:58:15Z

Looks really cool!

In the analysis screen (final part of the video), would it make sense to display the players' names above/below the board? The mobile site also does this.

julien4215 · 2024-08-27T20:13:56Z

Looks really cool!

In the analysis screen (final part of the video), would it make sense to display the players' names above/below the board? The mobile site also does this.

Yes, I also think it would be better with the players' names and clock/result.

veloce · 2024-08-29T07:44:55Z

Yeah, awesome work @julien4215 . I think we can release like that indeed, even without the eval bar. I'll deal with it asap. Right now I'm focusing on releasing the new editor and opening explorer so I think it'll be part of the next release.

…ound screen to a tab and create overview tab

veloce · 2024-09-03T07:51:24Z

I'm focusing right now on the next release but I'll review asap. Can you please fix the test and solve the conflict in the meantime? Thanks!

julien4215 · 2024-09-05T09:16:21Z

I'll fix the tests and the conflict once the PR is fully ready. I have to fix some problems with the clock and the analysis screen.

veloce · 2024-09-05T12:57:16Z

I'll fix the tests and the conflict once the PR is fully ready. I have to fix some problems with the clock and the analysis screen.

In that case I prefer that the PR is a draft. Easier for me to choose PR to review. Thanks!

veloce · 2024-11-22T17:39:34Z

So it is ready to review? Awesome. There's just a couple of conflicts to solve and I'll review this.

julien4215 · 2024-11-23T01:06:22Z

Yes it is ready to review.

I fixed the conflicts and I modified the code to use the new AnalysisLayout widget in the broadcast game screen.

veloce

Excellent work! I think we're getting close to release this. Only have a couple of comments here.

I'll test this next week, and figure out something about the dropdown menu bug, since I don't really want to patch flutter.

veloce · 2024-11-23T12:59:59Z

lib/src/view/analysis/analysis_board.dart

    this.enableDrawingShapes = true,
    this.shouldReplaceChildOnUserMove = false,
  });

  final AnalysisOptions options;
  final double boardSize;
-  final BorderRadiusGeometry? borderRadius;


I don't understand that. Why changing to radius instead of borderRadius?

Are you talking only about the name of the variable or the type ?

To add rounded corners to the players widgets instead of the board for broadcast like on the website

The change of the name is just to match the type

lib/src/view/broadcast/broadcast_boards_tab.dart

lib/src/view/broadcast/broadcast_game_screen.dart

lib/src/view/broadcast/broadcast_game_tree_view.dart

lib/src/view/broadcast/broadcast_screen.dart

lib/src/widgets/evaluation_bar.dart

lib/src/widgets/pgn.dart

veloce · 2024-11-23T13:27:05Z

lib/src/widgets/clock.dart

@@ -287,7 +287,8 @@ class _CountdownClockState extends State<CountdownClockBuilder> {
  void didUpdateWidget(CountdownClockBuilder oldClock) {
    super.didUpdateWidget(oldClock);

-    if (widget.clockUpdatedAt != oldClock.clockUpdatedAt) {
+    if (widget.timeLeft != oldClock.timeLeft ||


I don't think that change is a good idea. The way to clock is designed is to rely only on clockUpdatedAt to know when the clock has changed. We want to force update clockUpdateAt, and here you'd broke that contract.

Not sure to understand your comment. Do you mean that the only way to change the clock should be the clockUpdateAt field ?

The only way to indicate the clock has changed is to update clockUpdatedAt. Meaning if you want to update timeLeft you have to update clockUpdatedAt. We want to support updating the clock with the same time left, so this is the only way to ensure it.
If you don't provide at all the clockUpdatedAt it means timeLeft will never change.

You can read the tests in clock_test.dart to understand also, it contains the specification.

I don't understand why you are saying that

We want to support updating the clock with the same time left, so this is the only way to ensure it.

With what I have done you can still update the clock with the same time left.

The reason I needed to also update the clock when timeLeft change (which makes sense I think) is that on the broadcast game screen when going through the moves I need to display the clocks and the clocks are always inactive with no clockUpdatedAt value expect for the current broadcast path if the game is still ongoing.

What I could do instead is simply use a text widget but then why add an inactive field.

veloce · 2024-11-23T13:27:41Z

test/widgets/clock_test.dart

@@ -115,7 +115,7 @@ void main() {
      expect(find.text('0:00.0'), findsOneWidget);
    });

-    testWidgets('do not update if clockUpdatedAt is same',
+    testWidgets('do not update if timeLeft and clockUpdatedAt are same',


Cf. other comment, this change need to be removed.

…first release

julien4215 · 2024-11-23T21:36:45Z

I'll test this next week, and figure out something about the dropdown menu bug, since I don't really want to patch flutter.

Flutter fixed the issue on the master branch but I don't know when it will land in the beta.

If you don't want to patch Flutter maybe I can just copy the fixed dropdown menu widget in the broadcast folder for now and we remove it once it lands on the beta channel ?

veloce · 2024-11-25T16:44:02Z

I'll test this next week, and figure out something about the dropdown menu bug, since I don't really want to patch flutter.

Flutter fixed the issue on the master branch but I don't know when it will land in the beta.

If you don't want to patch Flutter maybe I can just copy the fixed dropdown menu widget in the broadcast folder for now and we remove it once it lands on the beta channel ?

Not sure about that. The problem with the dropdown menu is that we can't show more detailed info it seems. I think it would be very nice to show the round date as in the website, it is an important information. And it looks like we can't do it with DropdownMenu.

I wonder what is the alternative? Maybe showMenu and PopupMenuItem? https://api.flutter.dev/flutter/material/PopupMenuItem-class.html

julien4215 · 2024-11-25T18:52:43Z

The dropdown menu entries can be larger than the button so that should be possible to show more detailed information.

Maybe it can be done in a different pull request after merging this one ? This one is already bigger than what I planned to do.

tom-anders · 2024-11-25T20:26:39Z

The dropdown menu entries can be larger than the button so that should be possible to show more detailed information.

Maybe it can be done in a different pull request after merging this one ? This one is already bigger than what I planned to do.

Plus, people would probably be very excited if this feature is released before the WCC ends, even if some features are missing

veloce · 2024-11-26T09:09:44Z

You're right we'll see to improve the menu after. So you can put a copy of the widget in the meantime.

julien4215 · 2024-11-27T00:12:04Z

So you can put a copy of the widget in the meantime.

Done. I also merged main to get the new search time setting and the new ui for settings.

veloce · 2024-11-27T20:38:54Z

🎉 finally!

I must thank you again @julien4215 , this was a long journey but we finally made it! Thanks to your dedication and hard work. Congrats!

julien4215 · 2024-11-27T22:28:30Z

Happy to see it merged into main! And thanks for you thorough review.

I'll try to make smaller PR in the future. This one got a bit out of hand.

julien4215 force-pushed the broadcast-feature branch from c745d92 to 1c111f1 Compare August 27, 2024 08:28

julien4215 added 10 commits August 29, 2024 22:52

add a new screen with tabs for broadcast screen, move the broadcast r…

29eca30

…ound screen to a tab and create overview tab

add a dropdown menu to choose tournament in a group and round

c1ddc11

use user defined locale instead of default locale

82063f6

add broadcast board screen

1eaae20

use adaptive circular progress indicator for broadcast list screen

b292db3

tweak start round date on broadcast cards

acf391f

make status of game nullable

4c69c2c

fix round date starts show on broadcast grid card

8ba6d4d

add a link for broadcast in nb of hours and minutes translations

8474de8

handle case where tournament description is null

1913546

julien4215 force-pushed the broadcast-feature branch from 65c5deb to 1913546 Compare August 29, 2024 21:22

julien4215 added 2 commits August 29, 2024 23:44

use Cupertino style for the broadcast screen

92e4da1

add eval bar to board

af05482

julien4215 mentioned this pull request Aug 31, 2024

Add an evaluation bar to the board lichess-org/flutter-chessground#52

Closed

julien4215 added 2 commits September 1, 2024 14:56

add broadcast own game analysis screen with player and clock widget

0b05ebe

update comments and hide eval bar until it is ready

996b7e7

julien4215 marked this pull request as draft September 5, 2024 15:31

julien4215 added 4 commits September 6, 2024 13:49

fix timer by moving it in the controller

da08315

merge main into broadcast branch to fix android impeller issue

25dcbc6

rename broadcast game screeen to broadcast analysis screen

5adb49a

refactor player widget and fix negative clocks

f9ff0c4

julien4215 added 6 commits November 22, 2024 23:36

fix conflicts with upstream

943e003

use the new AnalysisLayout widget

3081d45

add again rounded borders

825dde5

fix lint error

dd822ad

fix last move not highlighted when opening a broadcast game

80ea3ca

really fix last move not highlighted

6459547

veloce reviewed Nov 23, 2024

View reviewed changes

julien4215 added 5 commits November 23, 2024 14:45

restore the PostFrameCallback for tree view removed by mistake

a364245

add translations

c72c703

add animation for boards thumbnails

5b3dda4

remove eval bar from this branch as it will not be part of broadcast …

ba243e1

…first release

watch whole state instead of using select

85be210

julien4215 added 2 commits November 26, 2024 19:11

add dropdown_menu fixed widget

7cd047d

merge upstream to get new search time analysis option

0236f6d

julien4215 added 4 commits November 27, 2024 01:32

fix linting

be74940

fix current node taking a wrong value

669c7c4

fix wrong broadcast path when not on current broadcast path

9b0aca0

remove old TODO and renaming

1db183e

veloce merged commit f34c092 into lichess-org:main Nov 27, 2024
1 check passed

julien4215 deleted the broadcast-feature branch November 27, 2024 22:10

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

More progress on broadcast feature #944

More progress on broadcast feature #944

julien4215 commented Aug 26, 2024 •

edited

Loading

ijm8710 commented Aug 26, 2024

ornicar commented Aug 26, 2024

tom-anders commented Aug 27, 2024 •

edited

Loading

julien4215 commented Aug 27, 2024 •

edited

Loading

veloce commented Aug 29, 2024

veloce commented Sep 3, 2024

julien4215 commented Sep 5, 2024

veloce commented Sep 5, 2024

veloce commented Nov 22, 2024

julien4215 commented Nov 23, 2024

veloce left a comment

veloce Nov 23, 2024

julien4215 Nov 23, 2024

veloce Nov 23, 2024

julien4215 Nov 23, 2024 •

edited

Loading

veloce Nov 23, 2024

julien4215 Nov 23, 2024 •

edited

Loading

veloce Nov 25, 2024 •

edited

Loading

veloce Nov 25, 2024

julien4215 Nov 26, 2024 •

edited

Loading

julien4215 Nov 26, 2024 •

edited

Loading

julien4215 Nov 26, 2024

veloce Nov 23, 2024

julien4215 commented Nov 23, 2024 •

edited

Loading

veloce commented Nov 25, 2024

julien4215 commented Nov 25, 2024 •

edited

Loading

tom-anders commented Nov 25, 2024 •

edited

Loading

veloce commented Nov 26, 2024

julien4215 commented Nov 27, 2024

veloce commented Nov 27, 2024

julien4215 commented Nov 27, 2024

More progress on broadcast feature #944

More progress on broadcast feature #944

Conversation

julien4215 commented Aug 26, 2024 • edited Loading

ijm8710 commented Aug 26, 2024

ornicar commented Aug 26, 2024

tom-anders commented Aug 27, 2024 • edited Loading

julien4215 commented Aug 27, 2024 • edited Loading

veloce commented Aug 29, 2024

veloce commented Sep 3, 2024

julien4215 commented Sep 5, 2024

veloce commented Sep 5, 2024

veloce commented Nov 22, 2024

julien4215 commented Nov 23, 2024

veloce left a comment

Choose a reason for hiding this comment

veloce Nov 23, 2024

Choose a reason for hiding this comment

julien4215 Nov 23, 2024

Choose a reason for hiding this comment

veloce Nov 23, 2024

Choose a reason for hiding this comment

julien4215 Nov 23, 2024 • edited Loading

Choose a reason for hiding this comment

veloce Nov 23, 2024

Choose a reason for hiding this comment

julien4215 Nov 23, 2024 • edited Loading

Choose a reason for hiding this comment

veloce Nov 25, 2024 • edited Loading

Choose a reason for hiding this comment

veloce Nov 25, 2024

Choose a reason for hiding this comment

julien4215 Nov 26, 2024 • edited Loading

Choose a reason for hiding this comment

julien4215 Nov 26, 2024 • edited Loading

Choose a reason for hiding this comment

julien4215 Nov 26, 2024

Choose a reason for hiding this comment

veloce Nov 23, 2024

Choose a reason for hiding this comment

julien4215 commented Nov 23, 2024 • edited Loading

veloce commented Nov 25, 2024

julien4215 commented Nov 25, 2024 • edited Loading

tom-anders commented Nov 25, 2024 • edited Loading

veloce commented Nov 26, 2024

julien4215 commented Nov 27, 2024

veloce commented Nov 27, 2024

julien4215 commented Nov 27, 2024

julien4215 commented Aug 26, 2024 •

edited

Loading

tom-anders commented Aug 27, 2024 •

edited

Loading

julien4215 commented Aug 27, 2024 •

edited

Loading

julien4215 Nov 23, 2024 •

edited

Loading

julien4215 Nov 23, 2024 •

edited

Loading

veloce Nov 25, 2024 •

edited

Loading

julien4215 Nov 26, 2024 •

edited

Loading

julien4215 Nov 26, 2024 •

edited

Loading

julien4215 commented Nov 23, 2024 •

edited

Loading

julien4215 commented Nov 25, 2024 •

edited

Loading

tom-anders commented Nov 25, 2024 •

edited

Loading