Allow offscreen reloading on all 4 sides of screen #178
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
Currently, many 3DO games only allow lightgun users to shoot off parts of the top of the screen in order to reload. This code change allows lightgun users to fire off any part of any side of the screen to reload in games that have a functioning reload/holster input. It is tested as working with all 3DO lightgun games except for Mad Dog McCree and Space Pirates, which still exhibit the issues outlined in #176, and it is also tested as working with the arcade game Shootout at Old Tucson (which didn't appear to have functioning offscreen reload before this).
I tried investigating the issues outlined in #176, but it seems that there is no place along the screen boundary that consistently acts as an out-of-bounds region for reloading for those two games. The emulator's reload button fires a shot at the middle of the top edge of the screen, which is enough for most games, but it doesn't work for Mad Dog McCree and Space Pirates for some reason.
Further, while testing this code with a friend, we found that 2 lightguns for 2-player games doesn't currently seem possible. I found the note in the code about how the gun acts as player 2, and I wonder if the fact that there are at least two different 3DO gun models is causing this. One model allows daisy chaining with a second gun, and the other only has a single controller plug. Perhaps an alternate device (dual lightguns?) that emulates two guns daisy chained is needed in order to get 2 players working?