Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new reference state data types to shared state #1042

Merged
merged 3 commits into from
Oct 4, 2023

Conversation

javierbrk
Copy link
Collaborator

Network reference state will be defined by the UI. The data types must be supported and sync using shared state. This package provides two new data types one for WiFi links information and the other for nodes available in the network

@codecov-commenter
Copy link

codecov-commenter commented Aug 25, 2023

Codecov Report

Merging #1042 (1fa531b) into master (44043c1) will decrease coverage by 0.03%.
The diff coverage is n/a.

❗ Current head 1fa531b differs from pull request most recent head 20e9dd3. Consider uploading reports for the commit 20e9dd3 to get more accurate results

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the GitHub App Integration for your organization. Read more.

@@            Coverage Diff             @@
##           master    #1042      +/-   ##
==========================================
- Coverage   79.75%   79.73%   -0.03%     
==========================================
  Files          53       53              
  Lines        4539     4539              
==========================================
- Hits         3620     3619       -1     
- Misses        919      920       +1     

see 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@G10h4ck G10h4ck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe this should be integrated directly into lime app package?

Plus see inline comments

TITLE:=Reference state datatypes module for shared-state
CATEGORY:=LibreMesh
URL:=http://libremesh.org
DEPENDS:= shared-state
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are you sure it is ok with the space after := anyway better get rid of it

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this make file has been removed

GIT_COMMIT_DATE:=$(shell git log -n 1 --pretty=%ad --date=short . )
GIT_COMMIT_TSTAMP:=$(shell git log -n 1 --pretty=%at . )

PKG_NAME:=shared-state-wifi_links_info
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the package name still appropriate?

Copy link
Collaborator Author

@javierbrk javierbrk Aug 28, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ups copy paste, this make file is no longer needed

@ilario
Copy link
Member

ilario commented Aug 25, 2023

Hi!
Two questions:

@G10h4ck
Copy link
Member

G10h4ck commented Aug 26, 2023

Yeah using libremesh.mk is in usually a good idea, anyway I have talked with @javierajorge and we concluded the two uci-defaults files that would be the only real addition from this package should instead be included in lime-app as the reference state stuff is all lime-app specific, so this PR will be closed once @javierbrk and @selankon include the contributed code in the proper package (lime-app os some of it's modules).

about upstreaming shared-state code to OpenWrt it is a good idea but not for now, ATM some parts of it like the neighbour candidate discovery does assumptions that are quite tied to libremesh network model even if it doesn't depends on it directly, so we would risk to upstream something that works badly on a different setup, I am working now on a new version of shared-stare that will be a more reasonable candidate for upstreaming to OpenWrt.

Cheers!

@javierbrk
Copy link
Collaborator Author

Here is an attempt to move the scripts into lime app package, what do you think ?

@G10h4ck
Copy link
Member

G10h4ck commented Aug 31, 2023

Here is an attempt to move the scripts into lime app package, what do you think ?

Seems fine to me, let's wait to hear @selankon if he thinks this is the proper place where to ship those uci-defaults

@G10h4ck G10h4ck added this to the mesh-wide milestone Oct 4, 2023
@G10h4ck G10h4ck merged commit 4569fec into libremesh:master Oct 4, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants