Drupal 10 Upgrade #13
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
humble-ahitofel
force-pushed
the
drupal-10-upgrade
branch
7 times, most recently
from
47a1d7d to
7da2f79
Compare
- Updated *.info.yml to be compatible with Drupal 10. - Replaced deprecated drupal_get_path() with extension.list.module service for module path retrieval. - Replaced deprecated jQuery $.once to pure javascript .once library. - Replaced deprecated entityManager with entityTypeManager. - Applied code style improvements using Rector for enhanced readability and consistency. - Added is_countable() checks before count(); lack of it results in a warning starting from PHP 7.2. - Standardized constant declarations to follow modern PHP visibility and style conventions. - Rewrote forms using ContentEntityForm to match the updated constructor in the latest Drupal core. - Replaced deprecated drupal_set_message() with \Drupal::messenger() ->addMessage() and \Drupal::messenger()->addWarning(). - Replaced deprecated urlInfo() with toUrl() for generating URLs. - Replaced deprecated entity url() with toUrl()->toString() for generating URL string. - Updated entity queries to explicitly manage access checks. - Replaced deprecated format_date() function with date.formatter service. - Added explicit array initialization to prevent warnings and ensure proper variable usage. - Replaced fully qualified class names with imported class names for improved readability. - Replaced deprecated pager_default_initialize() with pager.manager service for pager initialization. - Moved Rss::$base_field property initialization to the constructor to avoid potential conflicts and adhere to best practices. - Replaced deprecated entity_view() with entityTypeManager() ->getViewBuilder()->view() for rendering entities. - Replaced deprecated getVocabularyId() with bundle() for retrieving vocabulary IDs. - Replaced deprecated prepareQuery with prepareStatement. - Replaced deprecated getUsername() with getDisplayName() for retrieving user display names.
- Replaced hook_user_login with form submit handler for redirecting users, as the former caused login failures. - Removed leftover console.log from kifiform-tags-custom.js file.
- Hide asker's municipality and name in Question render. - Remove 'created' field from asklib_answer display. - Hide "title" label in Question view. Note: The hiding is currently implemented through code. Managing the Question display through the admin panel would be preferable.
humble-ahitofel
force-pushed
the
drupal-10-upgrade
branch
from
7da2f79 to
6d3311d
Compare
Kirjastot.fi search and Ask Libraries search need to be kept separate. For example, Asklib has its own sorting logic.
The indexing was broken for Questions. Additional setup for the QuestionSearch was added, ensuring proper indexing.
…le metadata This will resolve the issue with running the 'drush updatedb' when Drupal has been updated to 10.4 from 10.1.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ready for review.