Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add js-libp2p v0.46.x, rm v0.44, rm v0.45 browser tests #251

Merged
merged 5 commits into from
Aug 10, 2023
Merged

chore: add js-libp2p v0.46.x, rm v0.44, rm v0.45 browser tests #251

merged 5 commits into from
Aug 10, 2023

Conversation

p-shahi
Copy link
Member

@p-shahi p-shahi commented Aug 7, 2023

No description provided.

@p-shahi p-shahi requested a review from MarcoPolo August 7, 2023 23:29
@p-shahi p-shahi mentioned this pull request Aug 7, 2023
Closed
@p-shahi
Copy link
Member Author

p-shahi commented Aug 8, 2023

failed the following but unsure if flaky
firefox-js-v0.45 x firefox-js-v0.46 (webrtc),failure
chromium-js-v0.45 x firefox-js-v0.46 (webrtc),failure

@achingbrain
Copy link
Member

Refs: #235

@p-shahi
Copy link
Member Author

p-shahi commented Aug 8, 2023

The errors, I don't know if these are the same flaky errors seen elsewhere

2 failures [
  Error: Command failed: docker compose -f /tmp/compose-runner/firefox-js-v0-45-x-firefox-js-v0-46--webrtc-/compose.yaml up --exit-code-from=dialer --renew-anon-volumes
   Network firefox-js-v0_45_x_firefox-js-v0_46__webrtc__default  Creating
   Network firefox-js-v0_45_x_firefox-js-v0_46__webrtc__default  Created
   Container firefox-js-v0_45_x_firefox-js-v0_46__webrtc_-redis-1  Creating
   Container firefox-js-v0_45_x_firefox-js-v0_46__webrtc_-redis-1  Created
   Container firefox-js-v0_45_x_firefox-js-v0_46__webrtc_-listener-1  Creating
   Container firefox-js-v0_45_x_firefox-js-v0_46__webrtc_-dialer-1  Creating
   Container firefox-js-v0_45_x_firefox-js-v0_46__webrtc_-listener-1  Created
   Container firefox-js-v0_45_x_firefox-js-v0_46__webrtc_-dialer-1  Created
  firefox-js-v0_45_x_firefox-js-v0_46__webrtc_-listener-1  | - Setting up firefox
  firefox-js-v0_45_x_firefox-js-v0_46__webrtc_-dialer-1    | - Setting up firefox
  firefox-js-v0_45_x_firefox-js-v0_46__webrtc_-listener-1  | ✔ firefox set up
  firefox-js-v0_45_x_firefox-js-v0_46__webrtc_-dialer-1    | ✔ firefox set up
Warning: -js-v0_45_x_firefox-js-v0_46__webrtc_-listener-1  | ▲ [WARNING] Import "tcp" will always be undefined because the file "(disabled):../packages/transport-tcp/dist/src/index.js" has no exports [import-is-undefined]
  firefox-js-v0_45_x_firefox-js-v0_46__webrtc_-listener-1  | 
  firefox-js-v0_45_x_firefox-js-v0_46__webrtc_-listener-1  |     dist/test/ping.spec.js:7:9:
  firefox-js-v0_45_x_firefox-js-v0_46__webrtc_-listener-1  |       7 │ import { tcp } from '@libp2p/tcp';
  firefox-js-v0_45_x_firefox-js-v0_46__webrtc_-listener-1  |         ╵          ~~~
  firefox-js-v0_45_x_firefox-js-v0_46__webrtc_-listener-1  | 
  firefox-js-v0_45_x_firefox-js-v0_46__webrtc_-listener-1  | 
Warning: -js-v0_45_x_firefox-js-v0_46__webrtc_-dialer-1    | ▲ [WARNING] Import "tcp" will always be undefined because the file "(disabled):node_modules/@libp2p/tcp/dist/src/index.js" has no exports [import-is-undefined]
  firefox-js-v0_45_x_firefox-js-v0_46__webrtc_-dialer-1    | 
  firefox-js-v0_45_x_firefox-js-v0_46__webrtc_-dialer-1    |     dist/test/ping.spec.js:7:9:
  firefox-js-v0_45_x_firefox-js-v0_46__webrtc_-dialer-1    |       7 │ import { tcp } from '@libp2p/tcp';
  firefox-js-v0_45_x_firefox-js-v0_46__webrtc_-dialer-1    |         ╵          ~~~
  firefox-js-v0_45_x_firefox-js-v0_46__webrtc_-dialer-1    | 
  firefox-js-v0_45_x_firefox-js-v0_46__webrtc_-dialer-1    | 
  firefox-js-v0_45_x_firefox-js-v0_46__webrtc_-dialer-1    | node 12D3KooWCsJRgfZBzbepARa4esAVhzy1oqUnDa4wUo4UtUYQKSnP pings: /ip4/192.168.224.4/tcp/45633/ws/p2p/12D3KooWGWL8sMhQ3is2ZFgZ4iWMW4U888AYFGXywdQRSbzy8m32/p2p-circuit/webrtc/p2p/12D3KooWA4HfB8b7fdaWcMi17226cvSQLUdKRdepzRfQNWhreh7t
  firefox-js-v0_45_x_firefox-js-v0_46__webrtc_-dialer-1    | unexpected exception in ping test: Error: The operation was aborted
  firefox-js-v0_45_x_firefox-js-v0_46__webrtc_-dialer-1    | AbortError10@http://127.0.0.1:36673/bundle-out.js:92616:11
  firefox-js-v0_45_x_firefox-js-v0_46__webrtc_-dialer-1    | nextAbortHandler@http://127.0.0.1:36673/bundle-out.js:92666:22
  firefox-js-v0_45_x_firefox-js-v0_46__webrtc_-dialer-1    | abortHandler@http://127.0.0.1:36673/bundle-out.js:92653:11
  firefox-js-v0_45_x_firefox-js-v0_46__webrtc_-dialer-1    | onAbort@http://127.0.0.1:36673/bundle-out.js:90559:18
  firefox-js-v0_45_x_firefox-js-v0_46__webrtc_-dialer-1    | EventListener.handleEvent*anySignal2@http://127.0.0.1:36673/bundle-out.js:90572:17
  firefox-js-v0_45_x_firefox-js-v0_46__webrtc_-dialer-1    | ping@http://127.0.0.1:36673/bundle-out.js:96490:36
  firefox-js-v0_45_x_firefox-js-v0_46__webrtc_-dialer-1    | async*dist/test/ping.spec.js/</<@http://127.0.0.1:36673/bundle-out.js:96711:54
  firefox-js-v0_45_x_firefox-js-v0_46__webrtc_-dialer-1    | async*callFn@http://127.0.0.1:36673/bundle-out.js:14182:30
  firefox-js-v0_45_x_firefox-js-v0_46__webrtc_-dialer-1    | next@http://127.0.0.1:36673/bundle-out.js:15111:22
  firefox-js-v0_45_x_firefox-js-v0_46__webrtc_-dialer-1    | next@http://127.0.0.1:36673/bundle-out.js:15027:22
  firefox-js-v0_45_x_firefox-js-v0_46__webrtc_-dialer-1    | cbHookRun@http://127.0.0.1:36673/bundle-out.js:15083:19
  firefox-js-v0_45_x_firefox-js-v0_46__webrtc_-dialer-1    | done2@http://127.0.0.1:36673/bundle-out.js:14139:15
  firefox-js-v0_45_x_firefox-js-v0_46__webrtc_-dialer-1    | promise callback*callFn@http://127.0.0.1:36673/bundle-out.js:14185:22
  firefox-js-v0_45_x_firefox-js-v0_46__webrtc_-dialer-1    | next@http://127.0.0.1:36673/bundle-out.js:15045:19
  firefox-js-v0_45_x_firefox-js-v0_46__webrtc_-dialer-1    | timeslice@http://127.0.0.1:36673/bundle-out.js:18235:35
  firefox-js-v0_45_x_firefox-js-v0_46__webrtc_-dialer-1    | runAsync@http://127.0.0.1:36673/bundle-out.js:15452:18
  firefox-js-v0_45_x_firefox-js-v0_46__webrtc_-dialer-1    | runAsync@http://127.0.0.1:36673/bundle-out.js:18073:50
  firefox-js-v0_45_x_firefox-js-v0_46__webrtc_-dialer-1    | @debugger eval code line 197 > eval:2:4
  firefox-js-v0_45_x_firefox-js-v0_46__webrtc_-dialer-1    | evaluate@debugger eval code:197:30
  firefox-js-v0_45_x_firefox-js-v0_46__webrtc_-dialer-1    | @debugger eval code:1:44
  firefox-js-v0_45_x_firefox-js-v0_46__webrtc_-dialer-1    | 
  firefox-js-v0_45_x_firefox-js-v0_46__webrtc_-dialer-1    | 
  firefox-js-v0_45_x_firefox-js-v0_46__webrtc_-dialer-1    | Command failed with exit code 1: /app/interop/node_modules/.bin/pw-test test/**/*.spec.{js,cjs,mjs} test/browser.{js,cjs,mjs} dist/test/**/*.spec.{js,cjs,mjs} dist/test/browser.{js,cjs,mjs} --mode main --config /app/interop/node_modules/aegir/src/config/pw-test.js --browser firefox --timeout=60000
  Aborting on container exit...
   Container firefox-js-v0_45_x_firefox-js-v0_46__webrtc_-listener-1  Stopping
   Container firefox-js-v0_45_x_firefox-js-v0_46__webrtc_-dialer-1  Stopping
   Container firefox-js-v0_45_x_firefox-js-v0_46__webrtc_-dialer-1  Stopped
   Container firefox-js-v0_45_x_firefox-js-v0_46__webrtc_-listener-1  Stopped
   Container firefox-js-v0_45_x_firefox-js-v0_46__webrtc_-redis-1  Stopping
   Container firefox-js-v0_45_x_firefox-js-v0_46__webrtc_-redis-1  Stopped
  
      at ChildProcess.exithandler (node:child_process:419:12)
      at ChildProcess.emit (node:events:514:28)
      at ChildProcess.emit (node:domain:489:12)
      at maybeClose (node:internal/child_process:1091:16)
      at Process.ChildProcess._handle.onexit (node:internal/child_process:302:5) {
    code: 1,
    killed: false,
    signal: null,
    cmd: 'docker compose -f /tmp/compose-runner/firefox-js-v0-45-x-firefox-js-v0-46--webrtc-/compose.yaml up --exit-code-from=dialer --renew-anon-volumes',
    stdout: 'Attaching to firefox-js-v0_45_x_firefox-js-v0_46__webrtc_-dialer-1, firefox-js-v0_45_x_firefox-js-v0_46__webrtc_-listener-1, firefox-js-v0_45_x_firefox-js-v0_46__webrtc_-redis-1\n' +
      'firefox-js-v0_45_x_firefox-js-v0_46__webrtc_-redis-1     | 1:C 08 Aug 2023 04:24:20.649 # oO0OoO0OoO0Oo Redis is starting oO0OoO0OoO0Oo\n' +
      'firefox-js-v0_45_x_firefox-js-v0_46__webrtc_-redis-1     | 1:C 08 Aug 2023 04:24:20.649 # Redis version=7.0.12, bits=64, commit=00000000, modified=0, pid=1, just started\n' +
      'firefox-js-v0_45_x_firefox-js-v0_46__webrtc_-redis-1     | 1:C 08 Aug 2023 04:24:20.649 # Warning: no config file specified, using the default config. In order to specify a config file use redis-server /path/to/redis.conf\n' +
      'firefox-js-v0_45_x_firefox-js-v0_46__webrtc_-redis-1     | 1:M 08 Aug 2023 04:24:20.650 * monotonic clock: POSIX clock_gettime\n' +
      'firefox-js-v0_45_x_firefox-js-v0_46__webrtc_-redis-1     | 1:M 08 Aug 2023 04:24:20.650 * Running mode=standalone, port=6379.\n' +
      'firefox-js-v0_45_x_firefox-js-v0_46__webrtc_-redis-1     | 1:M 08 Aug 2023 04:24:20.650 # Server initialized\n' +
      "firefox-js-v0_45_x_firefox-js-v0_46__webrtc_-redis-1     | 1:M 08 Aug 2023 04:24:20.650 # WARNING Memory overcommit must be enabled! Without it, a background save or replication may fail under low memory condition. Being disabled, it can can also cause failures without low memory condition, see https://github.com/jemalloc/jemalloc/issues/1328. To fix this issue add 'vm.overcommit_memory = 1' to /etc/sysctl.conf and then reboot or run the command 'sysctl vm.overcommit_memory=1' for this to take effect.\n" +
      'firefox-js-v0_45_x_firefox-js-v0_46__webrtc_-redis-1     | 1:M 08 Aug 2023 04:24:20.650 * Ready to accept connections\n' +
      'firefox-js-v0_45_x_firefox-js-v0_46__webrtc_-dialer-1    | \n' +
      'firefox-js-v0_45_x_firefox-js-v0_46__webrtc_-dialer-1    | > [email protected] test\n' +
      'firefox-js-v0_45_x_firefox-js-v0_46__webrtc_-dialer-1    | > aegir test --build false --types false -t browser -- --browser firefox\n' +
      'firefox-js-v0_45_x_firefox-js-v0_46__webrtc_-dialer-1    | \n' +
      'firefox-js-v0_45_x_firefox-js-v0_46__webrtc_-dialer-1    | \n' +
      'firefox-js-v0_45_x_firefox-js-v0_46__webrtc_-listener-1  | \n' +
      'firefox-js-v0_45_x_firefox-js-v0_46__webrtc_-listener-1  | > [email protected] test:interop:multidim\n' +
      'firefox-js-v0_45_x_firefox-js-v0_46__webrtc_-listener-1  | > aegir test --build false --types false -t browser -- --browser firefox\n' +
      'firefox-js-v0_45_x_firefox-js-v0_46__webrtc_-listener-1  | \n' +
      'firefox-js-v0_45_x_firefox-js-v0_46__webrtc_-listener-1  | \n' +
      'firefox-js-v0_45_x_firefox-js-v0_46__webrtc_-listener-1  | test browser\n' +
      'firefox-js-v0_45_x_firefox-js-v0_46__webrtc_-dialer-1    | test browser\n' +
      'firefox-js-v0_45_x_firefox-js-v0_46__webrtc_-listener-1  | \x1B[0m\x1B[0m\n' +
      'firefox-js-v0_45_x_firefox-js-v0_46__webrtc_-listener-1  | \x1B[0m  ping test\x1B[0m\n' +
      'firefox-js-v0_45_x_firefox-js-v0_46__webrtc_-dialer-1    | \x1B[0m\x1B[0m\n' +
      'firefox-js-v0_45_x_firefox-js-v0_46__webrtc_-dialer-1    | \x1B[0m  ping test\x1B[0m\n' +
      'firefox-js-v0_45_x_firefox-js-v0_46__webrtc_-dialer-1    |   \x1B[36m  - should listen for ping\x1B[0m\n' +
      'firefox-js-v0_45_x_firefox-js-v0_46__webrtc_-dialer-1    |   \x1B[31m  1) should dial and ping\x1B[0m\n' +
      'firefox-js-v0_45_x_firefox-js-v0_46__webrtc_-dialer-1    | \x1B[92m \x1B[0m\x1B[32m 0 passing\x1B[0m\x1B[90m (13s)\x1B[0m\n' +
      'firefox-js-v0_45_x_firefox-js-v0_46__webrtc_-dialer-1    | \x1B[36m \x1B[0m\x1B[36m 1 pending\x1B[0m\n' +
      'firefox-js-v0_45_x_firefox-js-v0_46__webrtc_-dialer-1    | \x1B[31m  1 failing\x1B[0m\n' +
      'firefox-js-v0_45_x_firefox-js-v0_46__webrtc_-dialer-1    | \x1B[0m  1) ping test\n' +
      'firefox-js-v0_45_x_firefox-js-v0_46__webrtc_-dialer-1    |        should dial and ping:\n' +
      'firefox-js-v0_45_x_firefox-js-v0_46__webrtc_-dialer-1    | \x1B[0m\x1B[31m     The operation was aborted\x1B[0m\x1B[90m\n' +
      'firefox-js-v0_45_x_firefox-js-v0_46__webrtc_-dialer-1    |   AbortError10@http://127.0.0.1:36673/bundle-out.js:92616:11\n' +
      'firefox-js-v0_45_x_firefox-js-v0_46__webrtc_-dialer-1    |   nextAbortHandler@http://127.0.0.1:36673/bundle-out.js:92666:22\n' +
      'firefox-js-v0_45_x_firefox-js-v0_46__webrtc_-dialer-1    |   abortHandler@http://127.0.0.1:36673/bundle-out.js:92653:11\n' +
      'firefox-js-v0_45_x_firefox-js-v0_46__webrtc_-dialer-1    |   onAbort@http://127.0.0.1:36673/bundle-out.js:90559:18\n' +
      'firefox-js-v0_45_x_firefox-js-v0_46__webrtc_-dialer-1    |   EventListener.handleEvent*anySignal2@http://127.0.0.1:36673/bundle-out.js:90572:17\n' +
      'firefox-js-v0_45_x_firefox-js-v0_46__webrtc_-dialer-1    |   ping@http://127.0.0.1:36673/bundle-out.js:96490:36\n' +
      'firefox-js-v0_45_x_firefox-js-v0_46__webrtc_-dialer-1    |   async*dist/test/ping.spec.js/</<@http://127.0.0.1:36673/bundle-out.js:96711:54\n' +
      'firefox-js-v0_45_x_firefox-js-v0_46__webrtc_-dialer-1    |   async*callFn@http://127.0.0.1:36673/bundle-out.js:14182:30\n' +
      'firefox-js-v0_45_x_firefox-js-v0_46__webrtc_-dialer-1    |   next@http://127.0.0.1:36673/bundle-out.js:15111:22\n' +
      'firefox-js-v0_45_x_firefox-js-v0_46__webrtc_-dialer-1    |   next@http://127.0.0.1:36673/bundle-out.js:15027:22\n' +
      'firefox-js-v0_45_x_firefox-js-v0_46__webrtc_-dialer-1    |   cbHookRun@http://127.0.0.1:36673/bundle-out.js:15083:19\n' +
      'firefox-js-v0_45_x_firefox-js-v0_46__webrtc_-dialer-1    |   done2@http://127.0.0.1:36673/bundle-out.js:14139:15\n' +
      'firefox-js-v0_45_x_firefox-js-v0_46__webrtc_-dialer-1    |   promise callback*callFn@http://127.0.0.1:36673/bundle-out.js:14185:22\n' +
      'firefox-js-v0_45_x_firefox-js-v0_46__webrtc_-dialer-1    |   next@http://127.0.0.1:36673/bundle-out.js:15045:19\n' +
      'firefox-js-v0_45_x_firefox-js-v0_46__webrtc_-dialer-1    |   timeslice@http://127.0.0.1:36673/bundle-out.js:18235:35\n' +
      'firefox-js-v0_45_x_firefox-js-v0_46__webrtc_-dialer-1    |   runAsync@http://127.0.0.1:36673/bundle-out.js:15452:18\n' +
      'firefox-js-v0_45_x_firefox-js-v0_46__webrtc_-dialer-1    |   runAsync@http://127.0.0.1:36673/bundle-out.js:18073:50\n' +
      'firefox-js-v0_45_x_firefox-js-v0_46__webrtc_-dialer-1    |   @debugger eval code line 197 > eval:2:4\n' +
      'firefox-js-v0_45_x_firefox-js-v0_46__webrtc_-dialer-1    |   evaluate@debugger eval code:197:30\n' +
      'firefox-js-v0_45_x_firefox-js-v0_46__webrtc_-dialer-1    |   @debugger eval code:1:44\n' +
      'firefox-js-v0_45_x_firefox-js-v0_46__webrtc_-dialer-1    |   \n' +
      'firefox-js-v0_45_x_firefox-js-v0_46__webrtc_-dialer-1    | \x1B[0m\n' +
      'firefox-js-v0_45_x_firefox-js-v0_46__webrtc_-dialer-1 exited with code 1\n',
    stderr: ' Network firefox-js-v0_45_x_firefox-js-v0_46__webrtc__default  Creating\n' +
      ' Network firefox-js-v0_45_x_firefox-js-v0_46__webrtc__default  Created\n' +
      ' Container firefox-js-v0_45_x_firefox-js-v0_46__webrtc_-redis-1  Creating\n' +
      ' Container firefox-js-v0_45_x_firefox-js-v0_46__webrtc_-redis-1  Created\n' +
      ' Container firefox-js-v0_45_x_firefox-js-v0_46__webrtc_-listener-1  Creating\n' +
      ' Container firefox-js-v0_45_x_firefox-js-v0_46__webrtc_-dialer-1  Creating\n' +
      ' Container firefox-js-v0_45_x_firefox-js-v0_46__webrtc_-listener-1  Created\n' +
      ' Container firefox-js-v0_45_x_firefox-js-v0_46__webrtc_-dialer-1  Created\n' +
      'firefox-js-v0_45_x_firefox-js-v0_46__webrtc_-listener-1  | - Setting up firefox\n' +
      'firefox-js-v0_45_x_firefox-js-v0_46__webrtc_-dialer-1    | - Setting up firefox\n' +
      'firefox-js-v0_45_x_firefox-js-v0_46__webrtc_-listener-1  | ✔ firefox set up\n' +
      'firefox-js-v0_45_x_firefox-js-v0_46__webrtc_-dialer-1    | ✔ firefox set up\n' +
Warning: refox-js-v0_45_x_firefox-js-v0_46__webrtc_-listener-1  | ▲ [WARNING] Import "tcp" will always be undefined because the file "(disabled):../packages/transport-tcp/dist/src/index.js" has no exports [import-is-undefined]\n' +
      'firefox-js-v0_45_x_firefox-js-v0_46__webrtc_-listener-1  | \n' +
      'firefox-js-v0_45_x_firefox-js-v0_46__webrtc_-listener-1  |     dist/test/ping.spec.js:7:9:\n' +
      "firefox-js-v0_45_x_firefox-js-v0_46__webrtc_-listener-1  |       7 │ import { tcp } from '@libp2p/tcp';\n" +
      'firefox-js-v0_45_x_firefox-js-v0_46__webrtc_-listener-1  |         ╵          ~~~\n' +
      'firefox-js-v0_45_x_firefox-js-v0_46__webrtc_-listener-1  | \n' +
      'firefox-js-v0_45_x_firefox-js-v0_46__webrtc_-listener-1  | \n' +
Warning: refox-js-v0_45_x_firefox-js-v0_46__webrtc_-dialer-1    | ▲ [WARNING] Import "tcp" will always be undefined because the file "(disabled):node_modules/@libp2p/tcp/dist/src/index.js" has no exports [import-is-undefined]\n' +
      'firefox-js-v0_45_x_firefox-js-v0_46__webrtc_-dialer-1    | \n' +
      'firefox-js-v0_45_x_firefox-js-v0_46__webrtc_-dialer-1    |     dist/test/ping.spec.js:7:9:\n' +
      "firefox-js-v0_45_x_firefox-js-v0_46__webrtc_-dialer-1    |       7 │ import { tcp } from '@libp2p/tcp';\n" +
      'firefox-js-v0_45_x_firefox-js-v0_46__webrtc_-dialer-1    |         ╵          ~~~\n' +
      'firefox-js-v0_45_x_firefox-js-v0_46__webrtc_-dialer-1    | \n' +
      'firefox-js-v0_45_x_firefox-js-v0_46__webrtc_-dialer-1    | \n' +
      'firefox-js-v0_45_x_firefox-js-v0_46__webrtc_-dialer-1    | node 12D3KooWCsJRgfZBzbepARa4esAVhzy1oqUnDa4wUo4UtUYQKSnP pings: /ip4/192.168.224.4/tcp/45633/ws/p2p/12D3KooWGWL8sMhQ3is2ZFgZ4iWMW4U888AYFGXywdQRSbzy8m32/p2p-circuit/webrtc/p2p/12D3KooWA4HfB8b7fdaWcMi17226cvSQLUdKRdepzRfQNWhreh7t\n' +
      'firefox-js-v0_45_x_firefox-js-v0_46__webrtc_-dialer-1    | unexpected exception in ping test: Error: The operation was aborted\n' +
      'firefox-js-v0_45_x_firefox-js-v0_46__webrtc_-dialer-1    | AbortError10@http://127.0.0.1:36673/bundle-out.js:92616:11\n' +
      'firefox-js-v0_45_x_firefox-js-v0_46__webrtc_-dialer-1    | nextAbortHandler@http://127.0.0.1:36673/bundle-out.js:92666:22\n' +
      'firefox-js-v0_45_x_firefox-js-v0_46__webrtc_-dialer-1    | abortHandler@http://127.0.0.1:36673/bundle-out.js:92653:11\n' +
      'firefox-js-v0_45_x_firefox-js-v0_46__webrtc_-dialer-1    | onAbort@http://127.0.0.1:36673/bundle-out.js:90559:18\n' +
      'firefox-js-v0_45_x_firefox-js-v0_46__webrtc_-dialer-1    | EventListener.handleEvent*anySignal2@http://127.0.0.1:36673/bundle-out.js:90572:17\n' +
      'firefox-js-v0_45_x_firefox-js-v0_46__webrtc_-dialer-1    | ping@http://127.0.0.1:36673/bundle-out.js:96490:36\n' +
      'firefox-js-v0_45_x_firefox-js-v0_46__webrtc_-dialer-1    | async*dist/test/ping.spec.js/</<@http://127.0.0.1:36673/bundle-out.js:96711:54\n' +
      'firefox-js-v0_45_x_firefox-js-v0_46__webrtc_-dialer-1    | async*callFn@http://127.0.0.1:36673/bundle-out.js:14182:30\n' +
      'firefox-js-v0_45_x_firefox-js-v0_46__webrtc_-dialer-1    | next@http://127.0.0.1:36673/bundle-out.js:15111:22\n' +
      'firefox-js-v0_45_x_firefox-js-v0_46__webrtc_-dialer-1    | next@http://127.0.0.1:36673/bundle-out.js:15027:22\n' +
      'firefox-js-v0_45_x_firefox-js-v0_46__webrtc_-dialer-1    | cbHookRun@http://127.0.0.1:36673/bundle-out.js:15083:19\n' +
      'firefox-js-v0_45_x_firefox-js-v0_46__webrtc_-dialer-1    | done2@http://127.0.0.1:36673/bundle-out.js:14139:15\n' +
      'firefox-js-v0_45_x_firefox-js-v0_46__webrtc_-dialer-1    | promise callback*callFn@http://127.0.0.1:36673/bundle-out.js:14185:22\n' +
      'firefox-js-v0_45_x_firefox-js-v0_46__webrtc_-dialer-1    | next@http://127.0.0.1:36673/bundle-out.js:15045:19\n' +
      'firefox-js-v0_45_x_firefox-js-v0_46__webrtc_-dialer-1    | timeslice@http://127.0.0.1:36673/bundle-out.js:18235:35\n' +
      'firefox-js-v0_45_x_firefox-js-v0_46__webrtc_-dialer-1    | runAsync@http://127.0.0.1:36673/bundle-out.js:15452:18\n' +
      'firefox-js-v0_45_x_firefox-js-v0_46__webrtc_-dialer-1    | runAsync@http://127.0.0.1:36673/bundle-out.js:18073:50\n' +
      'firefox-js-v0_45_x_firefox-js-v0_46__webrtc_-dialer-1    | @debugger eval code line 197 > eval:2:4\n' +
      'firefox-js-v0_45_x_firefox-js-v0_46__webrtc_-dialer-1    | evaluate@debugger eval code:197:30\n' +
      'firefox-js-v0_45_x_firefox-js-v0_46__webrtc_-dialer-1    | @debugger eval code:1:44\n' +
      'firefox-js-v0_45_x_firefox-js-v0_46__webrtc_-dialer-1    | \n' +
      'firefox-js-v0_45_x_firefox-js-v0_46__webrtc_-dialer-1    | \n' +
      'firefox-js-v0_45_x_firefox-js-v0_46__webrtc_-dialer-1    | Command failed with exit code 1: /app/interop/node_modules/.bin/pw-test test/**/*.spec.{js,cjs,mjs} test/browser.{js,cjs,mjs} dist/test/**/*.spec.{js,cjs,mjs} dist/test/browser.{js,cjs,mjs} --mode main --config /app/interop/node_modules/aegir/src/config/pw-test.js --browser firefox --timeout=60000\n' +
      'Aborting on container exit...\n' +
      ' Container firefox-js-v0_45_x_firefox-js-v0_46__webrtc_-listener-1  Stopping\n' +
      ' Container firefox-js-v0_45_x_firefox-js-v0_46__webrtc_-dialer-1  Stopping\n' +
      ' Container firefox-js-v0_45_x_firefox-js-v0_46__webrtc_-dialer-1  Stopped\n' +
      ' Container firefox-js-v0_45_x_firefox-js-v0_46__webrtc_-listener-1  Stopped\n' +
      ' Container firefox-js-v0_45_x_firefox-js-v0_46__webrtc_-redis-1  Stopping\n' +
      ' Container firefox-js-v0_45_x_firefox-js-v0_46__webrtc_-redis-1  Stopped\n'
  },

  Error: Command failed: docker compose -f /tmp/compose-runner/chromium-js-v0-45-x-firefox-js-v0-46--webrtc-/compose.yaml up --exit-code-from=dialer --renew-anon-volumes
   Network chromium-js-v0_45_x_firefox-js-v0_46__webrtc__default  Creating
   Network chromium-js-v0_45_x_firefox-js-v0_46__webrtc__default  Created
   Container chromium-js-v0_45_x_firefox-js-v0_46__webrtc_-redis-1  Creating
   Container chromium-js-v0_45_x_firefox-js-v0_46__webrtc_-redis-1  Created
   Container chromium-js-v0_45_x_firefox-js-v0_46__webrtc_-listener-1  Creating
   Container chromium-js-v0_45_x_firefox-js-v0_46__webrtc_-dialer-1  Creating
   Container chromium-js-v0_45_x_firefox-js-v0_46__webrtc_-dialer-1  Created
   Container chromium-js-v0_45_x_firefox-js-v0_46__webrtc_-listener-1  Created
  chromium-js-v0_45_x_firefox-js-v0_46__webrtc_-listener-1  | - Setting up firefox
  chromium-js-v0_45_x_firefox-js-v0_46__webrtc_-dialer-1    | - Setting up chromium
  chromium-js-v0_45_x_firefox-js-v0_46__webrtc_-dialer-1    | ✔ chromium set up
Warning: m-js-v0_45_x_firefox-js-v0_46__webrtc_-dialer-1    | ▲ [WARNING] Import "tcp" will always be undefined because the file "(disabled):node_modules/@libp2p/tcp/dist/src/index.js" has no exports [import-is-undefined]
  chromium-js-v0_45_x_firefox-js-v0_46__webrtc_-dialer-1    | 
  chromium-js-v0_45_x_firefox-js-v0_46__webrtc_-dialer-1    |     dist/test/ping.spec.js:7:9:
  chromium-js-v0_45_x_firefox-js-v0_46__webrtc_-dialer-1    |       7 │ import { tcp } from '@libp2p/tcp';
  chromium-js-v0_45_x_firefox-js-v0_46__webrtc_-dialer-1    |         ╵          ~~~
  chromium-js-v0_45_x_firefox-js-v0_46__webrtc_-dialer-1    | 
  chromium-js-v0_45_x_firefox-js-v0_46__webrtc_-dialer-1    | 
  chromium-js-v0_45_x_firefox-js-v0_46__webrtc_-listener-1  | ✔ firefox set up
Warning: m-js-v0_45_x_firefox-js-v0_46__webrtc_-listener-1  | ▲ [WARNING] Import "tcp" will always be undefined because the file "(disabled):../packages/transport-tcp/dist/src/index.js" has no exports [import-is-undefined]
  chromium-js-v0_45_x_firefox-js-v0_46__webrtc_-listener-1  | 
  chromium-js-v0_45_x_firefox-js-v0_46__webrtc_-listener-1  |     dist/test/ping.spec.js:7:9:
  chromium-js-v0_45_x_firefox-js-v0_46__webrtc_-listener-1  |       7 │ import { tcp } from '@libp2p/tcp';
  chromium-js-v0_45_x_firefox-js-v0_46__webrtc_-listener-1  |         ╵          ~~~
  chromium-js-v0_45_x_firefox-js-v0_46__webrtc_-listener-1  | 
  chromium-js-v0_45_x_firefox-js-v0_46__webrtc_-listener-1  | 
  chromium-js-v0_45_x_firefox-js-v0_46__webrtc_-dialer-1    | node 12D3KooWQXhq2LukXVTXMjQXVzzJKfzA6cm83pmheP9NzUoiQ74c pings: /ip4/172.22.0.3/tcp/39777/ws/p2p/12D3KooWP27jHNPqHiAmoNayJxp5irrpbRVqSz4XWkmY2zsD4Q6e/p2p-circuit/webrtc/p2p/12D3KooWSgfDLTbRiiSrGfgFDJ62CADaYN4oDbcXe9FLbekqDxeR
  chromium-js-v0_45_x_firefox-js-v0_46__webrtc_-dialer-1    | unexpected exception in ping test: Error: The operation was aborted
  chromium-js-v0_45_x_firefox-js-v0_46__webrtc_-dialer-1    |     at nextAbortHandler (/app/node_modules/abortable-iterator/src/index.ts:85:20)
  chromium-js-v0_45_x_firefox-js-v0_46__webrtc_-dialer-1    |     at AbortSignal.abortHandler (/app/node_modules/abortable-iterator/src/index.ts:69:37)
  chromium-js-v0_45_x_firefox-js-v0_46__webrtc_-dialer-1    |     at AbortSignal.onAbort (/app/node_modules/any-signal/src/index.ts:14:16)
  chromium-js-v0_45_x_firefox-js-v0_46__webrtc_-dialer-1    | Command failed with exit code 1: /app/interop/node_modules/.bin/pw-test test/**/*.spec.{js,cjs,mjs} test/browser.{js,cjs,mjs} dist/test/**/*.spec.{js,cjs,mjs} dist/test/browser.{js,cjs,mjs} --mode main --config /app/interop/node_modules/aegir/src/config/pw-test.js --browser chromium --timeout=60000
  Aborting on container exit...
   Container chromium-js-v0_45_x_firefox-js-v0_46__webrtc_-listener-1  Stopping
   Container chromium-js-v0_45_x_firefox-js-v0_46__webrtc_-dialer-1  Stopping
   Container chromium-js-v0_45_x_firefox-js-v0_46__webrtc_-dialer-1  Stopped
   Container chromium-js-v0_45_x_firefox-js-v0_46__webrtc_-listener-1  Stopped
   Container chromium-js-v0_45_x_firefox-js-v0_46__webrtc_-redis-1  Stopping
   Container chromium-js-v0_45_x_firefox-js-v0_46__webrtc_-redis-1  Stopped
  
      at ChildProcess.exithandler (node:child_process:419:12)
      at ChildProcess.emit (node:events:514:28)
      at ChildProcess.emit (node:domain:489:12)
      at maybeClose (node:internal/child_process:1091:16)
      at Socket.<anonymous> (node:internal/child_process:449:11)
      at Socket.emit (node:events:514:28)
      at Socket.emit (node:domain:489:12)
      at Pipe.<anonymous> (node:net:323:12) {
    code: 1,
    killed: false,
    signal: null,
    cmd: 'docker compose -f /tmp/compose-runner/chromium-js-v0-45-x-firefox-js-v0-46--webrtc-/compose.yaml up --exit-code-from=dialer --renew-anon-volumes',
    stdout: 'Attaching to chromium-js-v0_45_x_firefox-js-v0_46__webrtc_-dialer-1, chromium-js-v0_45_x_firefox-js-v0_46__webrtc_-listener-1, chromium-js-v0_45_x_firefox-js-v0_46__webrtc_-redis-1\n' +
      'chromium-js-v0_45_x_firefox-js-v0_46__webrtc_-redis-1     | 1:C 08 Aug 2023 04:24:27.240 # oO0OoO0OoO0Oo Redis is starting oO0OoO0OoO0Oo\n' +
      'chromium-js-v0_45_x_firefox-js-v0_46__webrtc_-redis-1     | 1:C 08 Aug 2023 04:24:27.240 # Redis version=7.0.12, bits=64, commit=00000000, modified=0, pid=1, just started\n' +
      'chromium-js-v0_45_x_firefox-js-v0_46__webrtc_-redis-1     | 1:C 08 Aug 2023 04:24:27.240 # Warning: no config file specified, using the default config. In order to specify a config file use redis-server /path/to/redis.conf\n' +
      'chromium-js-v0_45_x_firefox-js-v0_46__webrtc_-redis-1     | 1:M 08 Aug 2023 04:24:27.240 * monotonic clock: POSIX clock_gettime\n' +
      'chromium-js-v0_45_x_firefox-js-v0_46__webrtc_-redis-1     | 1:M 08 Aug 2023 04:24:27.241 * Running mode=standalone, port=6379.\n' +
      'chromium-js-v0_45_x_firefox-js-v0_46__webrtc_-redis-1     | 1:M 08 Aug 2023 04:24:27.241 # Server initialized\n' +
      "chromium-js-v0_45_x_firefox-js-v0_46__webrtc_-redis-1     | 1:M 08 Aug 2023 04:24:27.241 # WARNING Memory overcommit must be enabled! Without it, a background save or replication may fail under low memory condition. Being disabled, it can can also cause failures without low memory condition, see https://github.com/jemalloc/jemalloc/issues/1328. To fix this issue add 'vm.overcommit_memory = 1' to /etc/sysctl.conf and then reboot or run the command 'sysctl vm.overcommit_memory=1' for this to take effect.\n" +
      'chromium-js-v0_45_x_firefox-js-v0_46__webrtc_-redis-1     | 1:M 08 Aug 2023 04:24:27.242 * Ready to accept connections\n' +
      'chromium-js-v0_45_x_firefox-js-v0_46__webrtc_-listener-1  | \n' +
      'chromium-js-v0_45_x_firefox-js-v0_46__webrtc_-listener-1  | > [email protected] test:interop:multidim\n' +
      'chromium-js-v0_45_x_firefox-js-v0_46__webrtc_-listener-1  | > aegir test --build false --types false -t browser -- --browser firefox\n' +
      'chromium-js-v0_45_x_firefox-js-v0_46__webrtc_-listener-1  | \n' +
      'chromium-js-v0_45_x_firefox-js-v0_46__webrtc_-listener-1  | \n' +
      'chromium-js-v0_45_x_firefox-js-v0_46__webrtc_-dialer-1    | \n' +
      'chromium-js-v0_45_x_firefox-js-v0_46__webrtc_-dialer-1    | > [email protected] test\n' +
      'chromium-js-v0_45_x_firefox-js-v0_46__webrtc_-dialer-1    | > aegir test --build false --types false -t browser -- --browser chromium\n' +
      'chromium-js-v0_45_x_firefox-js-v0_46__webrtc_-dialer-1    | \n' +
      'chromium-js-v0_45_x_firefox-js-v0_46__webrtc_-dialer-1    | \n' +
      'chromium-js-v0_45_x_firefox-js-v0_46__webrtc_-listener-1  | test browser\n' +
      'chromium-js-v0_45_x_firefox-js-v0_46__webrtc_-dialer-1    | test browser\n' +
      'chromium-js-v0_45_x_firefox-js-v0_46__webrtc_-dialer-1    | \x1B[0m\x1B[0m\n' +
      'chromium-js-v0_45_x_firefox-js-v0_46__webrtc_-dialer-1    | \x1B[0m  ping test\x1B[0m\n' +
      'chromium-js-v0_45_x_firefox-js-v0_46__webrtc_-dialer-1    |   \x1B[36m  - should listen for ping\x1B[0m\n' +
      'chromium-js-v0_45_x_firefox-js-v0_46__webrtc_-listener-1  | \x1B[0m\x1B[0m\n' +
      'chromium-js-v0_45_x_firefox-js-v0_46__webrtc_-listener-1  | \x1B[0m  ping test\x1B[0m\n' +
      'chromium-js-v0_45_x_firefox-js-v0_46__webrtc_-dialer-1    |   \x1B[31m  1) should dial and ping\x1B[0m\n' +
      'chromium-js-v0_45_x_firefox-js-v0_46__webrtc_-dialer-1    | \x1B[92m \x1B[0m\x1B[32m 0 passing\x1B[0m\x1B[90m (17s)\x1B[0m\n' +
      'chromium-js-v0_45_x_firefox-js-v0_46__webrtc_-dialer-1    | \x1B[36m \x1B[0m\x1B[36m 1 pending\x1B[0m\n' +
      'chromium-js-v0_45_x_firefox-js-v0_46__webrtc_-dialer-1    | \x1B[31m  1 failing\x1B[0m\n' +
      'chromium-js-v0_45_x_firefox-js-v0_46__webrtc_-dialer-1    | \x1B[0m  1) ping test\n' +
      'chromium-js-v0_45_x_firefox-js-v0_46__webrtc_-dialer-1    |        should dial and ping:\n' +
      'chromium-js-v0_45_x_firefox-js-v0_46__webrtc_-dialer-1    | \x1B[0m\x1B[31m     Error: The operation was aborted\x1B[0m\x1B[90m\n' +
      'chromium-js-v0_45_x_firefox-js-v0_46__webrtc_-dialer-1    |       at nextAbortHandler (/app/node_modules/abortable-iterator/src/index.ts:85:20)\n' +
      'chromium-js-v0_45_x_firefox-js-v0_46__webrtc_-dialer-1    |       at AbortSignal.abortHandler (/app/node_modules/abortable-iterator/src/index.ts:69:37)\n' +
      'chromium-js-v0_45_x_firefox-js-v0_46__webrtc_-dialer-1    |       at AbortSignal.onAbort (/app/node_modules/any-signal/src/index.ts:14:16)\n' +
      'chromium-js-v0_45_x_firefox-js-v0_46__webrtc_-dialer-1    | \x1B[0m\n' +
      'chromium-js-v0_45_x_firefox-js-v0_46__webrtc_-dialer-1 exited with code 1\n',
    stderr: ' Network chromium-js-v0_45_x_firefox-js-v0_46__webrtc__default  Creating\n' +
      ' Network chromium-js-v0_45_x_firefox-js-v0_46__webrtc__default  Created\n' +
      ' Container chromium-js-v0_45_x_firefox-js-v0_46__webrtc_-redis-1  Creating\n' +
      ' Container chromium-js-v0_45_x_firefox-js-v0_46__webrtc_-redis-1  Created\n' +
      ' Container chromium-js-v0_45_x_firefox-js-v0_46__webrtc_-listener-1  Creating\n' +
      ' Container chromium-js-v0_45_x_firefox-js-v0_46__webrtc_-dialer-1  Creating\n' +
      ' Container chromium-js-v0_45_x_firefox-js-v0_46__webrtc_-dialer-1  Created\n' +
      ' Container chromium-js-v0_45_x_firefox-js-v0_46__webrtc_-listener-1  Created\n' +
      'chromium-js-v0_45_x_firefox-js-v0_46__webrtc_-listener-1  | - Setting up firefox\n' +
      'chromium-js-v0_45_x_firefox-js-v0_46__webrtc_-dialer-1    | - Setting up chromium\n' +
      'chromium-js-v0_45_x_firefox-js-v0_46__webrtc_-dialer-1    | ✔ chromium set up\n' +
Warning: romium-js-v0_45_x_firefox-js-v0_46__webrtc_-dialer-1    | ▲ [WARNING] Import "tcp" will always be undefined because the file "(disabled):node_modules/@libp2p/tcp/dist/src/index.js" has no exports [import-is-undefined]\n' +
      'chromium-js-v0_45_x_firefox-js-v0_46__webrtc_-dialer-1    | \n' +
      'chromium-js-v0_45_x_firefox-js-v0_46__webrtc_-dialer-1    |     dist/test/ping.spec.js:7:9:\n' +
      "chromium-js-v0_45_x_firefox-js-v0_46__webrtc_-dialer-1    |       7 │ import { tcp } from '@libp2p/tcp';\n" +
      'chromium-js-v0_45_x_firefox-js-v0_46__webrtc_-dialer-1    |         ╵          ~~~\n' +
      'chromium-js-v0_45_x_firefox-js-v0_46__webrtc_-dialer-1    | \n' +
      'chromium-js-v0_45_x_firefox-js-v0_46__webrtc_-dialer-1    | \n' +
      'chromium-js-v0_45_x_firefox-js-v0_46__webrtc_-listener-1  | ✔ firefox set up\n' +
Warning: romium-js-v0_45_x_firefox-js-v0_46__webrtc_-listener-1  | ▲ [WARNING] Import "tcp" will always be undefined because the file "(disabled):../packages/transport-tcp/dist/src/index.js" has no exports [import-is-undefined]\n' +
      'chromium-js-v0_45_x_firefox-js-v0_46__webrtc_-listener-1  | \n' +
      'chromium-js-v0_45_x_firefox-js-v0_46__webrtc_-listener-1  |     dist/test/ping.spec.js:7:9:\n' +
      "chromium-js-v0_45_x_firefox-js-v0_46__webrtc_-listener-1  |       7 │ import { tcp } from '@libp2p/tcp';\n" +
      'chromium-js-v0_45_x_firefox-js-v0_46__webrtc_-listener-1  |         ╵          ~~~\n' +
      'chromium-js-v0_45_x_firefox-js-v0_46__webrtc_-listener-1  | \n' +
      'chromium-js-v0_45_x_firefox-js-v0_46__webrtc_-listener-1  | \n' +
      'chromium-js-v0_45_x_firefox-js-v0_46__webrtc_-dialer-1    | node 12D3KooWQXhq2LukXVTXMjQXVzzJKfzA6cm83pmheP9NzUoiQ74c pings: /ip4/172.22.0.3/tcp/39777/ws/p2p/12D3KooWP27jHNPqHiAmoNayJxp5irrpbRVqSz4XWkmY2zsD4Q6e/p2p-circuit/webrtc/p2p/12D3KooWSgfDLTbRiiSrGfgFDJ62CADaYN4oDbcXe9FLbekqDxeR\n' +
      'chromium-js-v0_45_x_firefox-js-v0_46__webrtc_-dialer-1    | unexpected exception in ping test: Error: The operation was aborted\n' +
      'chromium-js-v0_45_x_firefox-js-v0_46__webrtc_-dialer-1    |     at nextAbortHandler (/app/node_modules/abortable-iterator/src/index.ts:85:20)\n' +
      'chromium-js-v0_45_x_firefox-js-v0_46__webrtc_-dialer-1    |     at AbortSignal.abortHandler (/app/node_modules/abortable-iterator/src/index.ts:69:37)\n' +
      'chromium-js-v0_45_x_firefox-js-v0_46__webrtc_-dialer-1    |     at AbortSignal.onAbort (/app/node_modules/any-signal/src/index.ts:14:16)\n' +
      'chromium-js-v0_45_x_firefox-js-v0_46__webrtc_-dialer-1    | Command failed with exit code 1: /app/interop/node_modules/.bin/pw-test test/**/*.spec.{js,cjs,mjs} test/browser.{js,cjs,mjs} dist/test/**/*.spec.{js,cjs,mjs} dist/test/browser.{js,cjs,mjs} --mode main --config /app/interop/node_modules/aegir/src/config/pw-test.js --browser chromium --timeout=60000\n' +
      'Aborting on container exit...\n' +
      ' Container chromium-js-v0_45_x_firefox-js-v0_46__webrtc_-listener-1  Stopping\n' +
      ' Container chromium-js-v0_45_x_firefox-js-v0_46__webrtc_-dialer-1  Stopping\n' +
      ' Container chromium-js-v0_45_x_firefox-js-v0_46__webrtc_-dialer-1  Stopped\n' +
      ' Container chromium-js-v0_45_x_firefox-js-v0_46__webrtc_-listener-1  Stopped\n' +
      ' Container chromium-js-v0_45_x_firefox-js-v0_46__webrtc_-redis-1  Stopping\n' +
      ' Container chromium-js-v0_45_x_firefox-js-v0_46__webrtc_-redis-1  Stopped\n'
  }

@MarcoPolo
Copy link
Contributor

The browser webrtc tests are flaky unfortunately. I haven't debugged yet whether it's the browser webrtic implementation that is flaky or js-libp2p. See #235

@MarcoPolo
Copy link
Contributor

I think this has the effect of increasing the total flakiness failure rate by simplying adding more flaky webrtc tests.

For now I recommend removing the old webrtc browser tests (chromium/firefox on js-libp2p v0.45) and replacing them with this version.

@p-shahi
Copy link
Member Author

p-shahi commented Aug 9, 2023

I think this has the effect of increasing the total flakiness failure rate by simplying adding more flaky webrtc tests.

For now I recommend removing the old webrtc browser tests (chromium/firefox on js-libp2p v0.45) and replacing them with this version.

I also removed chromium-js-v0.44

@p-shahi p-shahi changed the title feat: add js-libp2p v0.46.x chore: add js-libp2p v0.46.x, rm v0.44, rm v0.45 browser tests Aug 10, 2023
@p-shahi p-shahi merged commit b0b8ad8 into master Aug 10, 2023
2 checks passed
@p-shahi p-shahi deleted the add-js-libp2p-46 branch August 10, 2023 03:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarcoPolo MarcoPolo MarcoPolo approved these changes

@achingbrain achingbrain Awaiting requested review from achingbrain

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@p-shahi @achingbrain @MarcoPolo