-
Notifications
You must be signed in to change notification settings - Fork 961
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(relay): external addr not expiring when relayed listen addr expire #5577
Open
stormshield-frb
wants to merge
7
commits into
libp2p:master
Choose a base branch
from
stormshield-frb:fix/relay-not-expiring-external-address
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
fix(relay): external addr not expiring when relayed listen addr expire #5577
stormshield-frb
wants to merge
7
commits into
libp2p:master
from
stormshield-frb:fix/relay-not-expiring-external-address
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stormshield-frb
force-pushed
the
fix/relay-not-expiring-external-address
branch
from
August 29, 2024 08:19
96bff78
to
6aff4f8
Compare
stormshield-frb
changed the title
fix(relay): relayed external address not expiring when stopping to listen through relay
fix(relay): external address not expiring when stopping to listen relay
Aug 29, 2024
stormshield-frb
changed the title
fix(relay): external address not expiring when stopping to listen relay
fix(relay): external addr not expiring when relayed listen addr expire
Aug 29, 2024
stormshield-frb
force-pushed
the
fix/relay-not-expiring-external-address
branch
3 times, most recently
from
August 29, 2024 15:33
5bceae6
to
d24cf31
Compare
stormshield-frb
force-pushed
the
fix/relay-not-expiring-external-address
branch
2 times, most recently
from
August 29, 2024 20:02
eeefabb
to
cfb5cd1
Compare
…sten through relay
stormshield-frb
force-pushed
the
fix/relay-not-expiring-external-address
branch
from
August 29, 2024 20:05
cfb5cd1
to
2918c54
Compare
Thanks! Just as an fyi, there is no need to force push as the commits will all be squashed when it is merged. |
stormshield-frb
force-pushed
the
fix/relay-not-expiring-external-address
branch
from
October 24, 2024 08:29
479b360
to
bac825e
Compare
This pull request has merge conflicts. Could you please resolve them @stormshield-frb? 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We encountered a bug when our app is connected and listening through a relay and that it decided to stop listening through the relay but still let the connection with the relay open (some other streams are opened with this peer), then the previously confirmed
ExternalAddress
does not expire.The PR solves this problem and simplify a little bit the way to emit
ExternalAddrConfirmed
andExternalAddrExpired
by only watchingNewListenAddr
andExpiredListenAddr
events if they are notifying about a relayed listen address.Also, when renewing reservation,
NewListenAddr
should not be emitted again if the samelisten_addr
is given, but it should emit aListenAddrExpired
event if a previously reserved one was not reserved again.Notes & open questions
I have also included a correlated change by removing the
/p2p/<local_peer_id>
of the relayed listen addresses and external addresses (corresponding to a listen addresses). Indeed, every other transport does not include it so I think it is better that therelay
transport acts the same. If necessary, I can do a separated PR.Change checklist