Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove browser dial filter #2838

Merged
merged 6 commits into from
Nov 25, 2024
Merged

fix: remove browser dial filter #2838

merged 6 commits into from
Nov 25, 2024

Conversation

achingbrain
Copy link
Member

The filter functionality here is covered by the connection gater in libp2p itself so there's no need to duplicate it at the transport level.

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation if necessary (this includes comments as well)
  • I have added tests that prove my fix is effective or that my feature works

@achingbrain
fix: remove browser dial filter
7367f56 
The filter functionality here is covered by the connection gater
in libp2p itself so there's no need to duplicate it at the transport
level.
@achingbrain achingbrain requested a review from a team as a code owner November 22, 2024 16:11
@achingbrain achingbrain merged commit d6cd25d into main Nov 25, 2024
33 of 34 checks passed
@achingbrain achingbrain deleted the fix/remove-browser-filter branch November 25, 2024 08:59
@achingbrain achingbrain mentioned this pull request Nov 25, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SgtPooki SgtPooki SgtPooki approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@achingbrain @SgtPooki