fix: send raw plaintext public key during handshake #2599
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In js, all "public keys" are marshaled using protobuf PublicKey message. However, according to [specs](https://github.com/libp2p/specs/blob/master/plaintext/README.md) and other implementations, the `Data` field should contains the raw key, instead of the protobuf marshaled key, and then put in to the exchange. Otherwise, js-libp2p will not connect to golang or rust libp2p, raising the "Public key did not match id" error.
achingbrain
reviewed
Jun 21, 2024
Co-authored-by: Alex Potsides <[email protected]>
|
So weird that tests are still failed. I think I have finished all the changes required... have no clue now |
achingbrain
approved these changes
Aug 16, 2024
achingbrain
changed the title
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title
fix: make plaintext public key follow to the specs
Description
In js, all "public keys" are marshaled using protobuf PublicKey message.
However, according to specs and other implementations, the
Datafield should contains the raw key, instead of the protobuf marshaled key, and then put in to the exchange.Otherwise, js-libp2p will not connect to golang or rust libp2p, raising the "Public key did not match id" error, if only plaintext selected for encryption.
Notes & open questions
Should we involve some cross-implementation tests to check if any further issue like that?
Change checklist