Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: move mplex capabilities to the factory #2597

Merged
merged 1 commit into from
Jun 23, 2024
Merged

fix: move mplex capabilities to the factory #2597

merged 1 commit into from
Jun 23, 2024

Conversation

achingbrain
Copy link
Member

These should be defined on the factory not the instance, since the factory is the component.

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation if necessary (this includes comments as well)
  • I have added tests that prove my fix is effective or that my feature works

@achingbrain
fix: move mplex capabilities to the factory
48e743d 
These should be defined on the factory not the instance, since the
factory is the component.
@achingbrain achingbrain requested a review from a team as a code owner June 19, 2024 17:27
@wemeetagain wemeetagain merged commit 0b55625 into main Jun 23, 2024
24 checks passed
@wemeetagain wemeetagain deleted the fix/mplex-capabilities branch June 23, 2024 20:59
@achingbrain achingbrain mentioned this pull request Jun 23, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maschad maschad maschad approved these changes

@wemeetagain wemeetagain wemeetagain approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@achingbrain @wemeetagain @maschad