Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: create RTCPeerConnection after dialing remote peer #2593

Merged
merged 4 commits into from
Jun 18, 2024
Merged

fix: create RTCPeerConnection after dialing remote peer #2593

merged 4 commits into from
Jun 18, 2024

Commits on Jun 17, 2024

  1. fix: create RTCPeerConnection after dialing remote peer 

    Chrome limits how many RTCPeerConnections a given tab can instantiated
during it's lifetime - https://issues.chromium.org/issues/41378764

To delay hitting this limit, only create the dial-end RTCPeerConnection
once a relayed connection has successfully been opened to the dial
target, this prevents needlessly creating RTCPeerConnections when the
dial fails before they are actually used.

Fixes #2591
    @achingbrain
    achingbrain committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    ee395a5 View commit details
    Browse the repository at this point in the history

  2. chore: fix tests

    @achingbrain
    achingbrain committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    35ac635 View commit details
    Browse the repository at this point in the history

Commits on Jun 18, 2024

  1. chore: ensure early streams are captured

    @achingbrain
    achingbrain committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    bfcea64 View commit details
    Browse the repository at this point in the history

  2. chore: tests can be fast

    @achingbrain
    achingbrain committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    a1e7b0e View commit details
    Browse the repository at this point in the history