Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow passing a function for rtcConfiguration #2590

Merged
merged 2 commits into from
Jun 18, 2024

Conversation

achingbrain
Copy link
Member

In order to allow refreshing STUN/TURN credentials between dials, allow passing a function that returns rtc config.

Fixes #2554

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation if necessary (this includes comments as well)
  • I have added tests that prove my fix is effective or that my feature works

In order to allow refreshing STUN/TURN credentials between dials,
allow passing a function that returns rtc config.

Fixes #2554
@achingbrain achingbrain requested a review from a team as a code owner June 14, 2024 15:06
@achingbrain
Copy link
Member Author

cc @justin0mcateer

@achingbrain achingbrain changed the title fix: allow passing a function for rtcConfiguration feat: allow passing a function for rtcConfiguration Jun 18, 2024
@achingbrain achingbrain merged commit 9e02366 into main Jun 18, 2024
25 checks passed
@achingbrain achingbrain deleted the fix/allow-passing-function-for-rtcconfiguration branch June 18, 2024 12:30
@achingbrain achingbrain mentioned this pull request Jun 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Update RTCConfig for WebRTCTransport
1 participant