Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add Elena to Rust libp2p maintainers #262

Merged
merged 8 commits into from
Nov 20, 2024

Conversation

jxs
Copy link
Member

@jxs jxs commented Nov 18, 2024

As she's back contributing with us.
cc @guillaumemichel @dariusc93

@jxs jxs requested review from a team as code owners November 18, 2024 10:36
Copy link
Contributor

github-actions bot commented Nov 18, 2024

The following access changes will be introduced as a result of applying the plan:

Access Changes
There will be no access changes

@galargh
Copy link
Contributor

galargh commented Nov 18, 2024

A sync failed yesterday, I'm rerunning it now. After that, the plan will rerun here.

@@ -5472,6 +5472,7 @@ teams:
members:
maintainer:
- AgeManning
- elenaf9
Copy link
Member

@p-shahi p-shahi Nov 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you have to remove Elena's username from the member list @jxs (since now it's duplicated in two lists maintainer and member)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is correct. The other issue that I mentioned - the one with sync - is already resolved.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! Updated

Copy link
Contributor

Before merge, verify that all the following plans are correct. They will be applied as-is after the merge.

Terraform plans

libp2p

Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
  ~ update in-place
  - destroy

Terraform will perform the following actions:

  # github_team_membership.this["alumni:elenaf9"] will be destroyed
  # (because key ["alumni:elenaf9"] is not in for_each map)
  - resource "github_team_membership" "this" {
      - etag     = "W/\"b55ec009c609a2c629e432edf9d41bd599f4f05f3af5587ab51790ac1f356505\"" -> null
      - id       = "6201424:elenaf9" -> null
      - role     = "member" -> null
      - team_id  = "6201424" -> null
      - username = "elenaf9" -> null
    }

  # github_team_membership.this["rust-libp2p maintainers:elenaf9"] will be updated in-place
  ~ resource "github_team_membership" "this" {
        id       = "11402594:elenaf9"
      ~ role     = "member" -> "maintainer"
        # (3 unchanged attributes hidden)
    }

Plan: 0 to add, 1 to change, 1 to destroy.

@p-shahi p-shahi merged commit 963f199 into libp2p:master Nov 20, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants