-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
entry: move entries within a group #347
Conversation
Is just for feature parity with the |
Perhaps it would be better to call this
How do you do this in KeePassXC? As far as I can tell, the entries are just automatically sorted by Title/Username/URL/etc. |
As you sugggested I added a test and I rename the function to |
Thanks! This looks good so far. Would you mind adding docstrings on |
Shouldn't it be near |
d206474
to
b400b62
Compare
b400b62
to
4e3b0a3
Compare
Actually there doesn't appear to be sections for Group/Entry member functions in the README, so you can ignore that for now. Thanks for the contribution! |
Code changes:
index
property to Entrymove
method to Entry_first_entry
property to GroupExplanation:
To move Entries around we need to remove and then insert at the desired index, the KDBX format makes it so that Entries and group info is all mixed, so we have to get the first element index to position correctly the Entries.
If you know a better method to get the index of the first entry I'll put it in.
What it does:
It moves entries around a group, pretty self explanatory, like the Keepass and KeepassXC functionality.