Better control referencing #506
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and apply the override by default to the profile_noindex setting
since every community has a row in the participants table we can use hide_from_lists instead
this effectively enables noindex and nofollow on all of them
Changaco
added
Review
defense
|
Related issue: liberapay/liberapay.org#15. |
Changaco
force-pushed
the
control-referencing
branch
from
119f9b8
to
9133478
Compare
|
This is in production, no errors during deployment. |
|
However, since I chose to apply the schema changes after deployment, postgres.py was still treating the modified participant columns as booleans (this is a corner case that wasn't fixed by liberapay/postgres.py#43). Restarting the workers fixed the problem ( |
|
I completely forgot to add a checkbox for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is the first step towards fixing #487.
Our Terms of Service state:
However blocking a user's access to "publicity" wasn't actually implemented. Once this PR is deployed all user profiles, as well as community and pledge pages, will have
noindexandnofollowturned on by default, and admins will also be able to prevent pages from being listed on Liberapay (hide_from_lists) and appearing in search results (hide_from_search).I'm tagging this PR with "Self-defense" because it's about preventing "naughty" people from abusing Liberapay.