Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add getStarkProfiles function & tests #32

Merged
merged 7 commits into from
Apr 23, 2024
Merged

Conversation

irisdv
Copy link
Collaborator

@irisdv irisdv commented Apr 4, 2024

Close #30

This PR :

  • moves some utils functions into a new internal file
  • adds a try catch for all calls that included a call to address_to_domain. We will first try to make the call with a hint parameter, if it fails we will make the call without the hint parameter.
  • Blobbert tokenURI function was taking too much resources and resulted in the function getStarkProfiles returning an error whenever there was more than one profile with a Blobbert. For now, we don't retrieve those. We contacted the team and we will find a way (maybe offchain) to serve the token uri of users that have set a Blobbert as there pfp.

@irisdv irisdv added the 🔥 Ready for review This pull request needs a review label Apr 9, 2024
Copy link
Contributor

@fricoben fricoben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@irisdv irisdv added 🚧 In progress do not merge Pull Request in progress, please do not merge and removed 🔥 Ready for review This pull request needs a review labels Apr 18, 2024
@irisdv irisdv added 🔥 Ready for review This pull request needs a review and removed 🚧 In progress do not merge Pull Request in progress, please do not merge labels Apr 19, 2024
Copy link
Member

@Th0rgal Th0rgal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Th0rgal Th0rgal merged commit 8754a90 into main Apr 23, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔥 Ready for review This pull request needs a review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create getStarkProfiles
3 participants