Added okxwallet

[Emmanex01]

I addded an okxwallet

Please add the labels corresponding to the type of changes your PR introduces:

• Bugfix
• Feature
• Code style update (formatting, renaming)
• Refactoring (no functional changes, no API changes)
• Build-related changes
• Documentation content changes
• Testing
• Other (please describe):

Resolves: #908

Other information

Summary by CodeRabbit

• New Features
  • Introduced "Okx Wallet" as a new connectivity option for users, enhancing wallet integration in the application.

[vercel]

@Emmanex01 is attempting to deploy a commit to the LFG Labs Team on Vercel.

A member of the Team first needs to authorize it.

[coderabbitai]

Walkthrough

The changes introduce a new wallet connector, InjectedConnector, for "Okx Wallet" to the availableConnectors array in the app/provider.tsx file. This addition allows users to connect using the Okx Wallet without altering the existing connectors or the overall structure of the Providers function. The configuration for network determination and StarknetConfig remains unchanged, ensuring compatibility with the current application setup.

Changes

File	Change Summary
app/provider.tsx	Added InjectedConnector for "Okx Wallet" to availableConnectors with options { id: "okxwallet", name: "Okx Wallet" }.

Assessment against linked issues

Objective	Addressed	Explanation
Add OKX wallet (Issue #908)	✅

Possibly related PRs

• feat: Add keplr wallet #901  #906: The addition of the "Keplr" wallet connector in the same availableConnectors array in app/provider.tsx indicates a similar modification pattern to the new "Okx Wallet" connector.

Suggested reviewers

• fricoben

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Outside diff range and nitpick comments (1)

app/provider.tsx (1)

40-40: Consider optimizing wallet connector order.

The OKX wallet is positioned between Argent X and Web Wallet. Consider grouping similar wallet types together (e.g., all injected wallets) for better UX.

Consider this ordering:

  new InjectedConnector({ options: { id: "braavos", name: "Braavos" } }),
  new InjectedConnector({ options: { id: "argentX", name: "Argent X" } }),
+ new InjectedConnector({ options: { id: "keplr", name: "Keplr" } }),
  new InjectedConnector({ options: { id: "okxwallet", name: "Okx Wallet" } }),
  new WebWalletConnector({
    url: getCurrentNetwork() === "TESTNET"
      ? "https://web.hydrogen.argent47.net"
      : "https://web.argent.xyz/",
  }),
  new ArgentMobileConnector({
    dappName: "Starknet Quest",
    url: process.env.NEXT_PUBLIC_APP_LINK as string,
    chainId: constants.NetworkName.SN_MAIN,
    icons: ["https://starknet.quest/visuals/starknetquestLogo.svg"],
  }),
- new InjectedConnector({ options: { id: "keplr", name: "Keplr" } })

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between 286d3f1 and 4db88f4.

📒 Files selected for processing (1)

• app/provider.tsx (1 hunks)

🔇 Additional comments (1)

app/provider.tsx (1)

40-40: Implementation looks good, but needs runtime verification.

The OKX wallet integration follows the correct pattern using InjectedConnector. However, we should ensure proper error handling when the wallet is not available.

Let's verify the wallet integration pattern across the codebase:

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
starknet-quest	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Oct 27, 2024 8:08pm

[Marchand-Nicolas]

Lgtm!