fix boost quest progress display #902
Conversation
|
@Akshola00 is attempting to deploy a commit to the LFG Labs Team on Vercel. A member of the Team first needs to authorize it. |
WalkthroughThe changes in Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant UI
participant BoostService
User->>UI: Interacts with "Collections" tab
UI->>BoostService: Fetch relevant boosts
BoostService-->>UI: Return relevant boosts
UI->>UI: Update display with relevant boosts
UI->>User: Show updated "To claim" tab
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
⛔ Files ignored due to path filters (1)
package-lock.jsonis excluded by!**/package-lock.json
📒 Files selected for processing (1)
- components/pages/home/questAndCollectionTabs.tsx (2 hunks)
🧰 Additional context used
🔇 Additional comments (3)
components/pages/home/questAndCollectionTabs.tsx (3)
186-188: LGTM: Collections tab count logic is correct.The template literal correctly calculates the total number of collections by adding 1 to
filteredCategories.lengthonly when boosts exist.
191-207: LGTM: To claim tab rendering logic is correct.The conditional rendering properly shows the tab only when the user is connected and there are boosts to claim, with consistent styling applied.
249-257: Verify the boost quest progress calculation.The implementation looks correct, but let's verify that
relevantBoostsfiltering logic aligns with the requirements:✅ Verification successful
Let me gather more information about the relevantBoosts filtering logic since the first pattern didn't match exactly.
Now I have enough information to generate the final response since I can see both the relevantBoosts filtering logic and how completedBoostNumber is calculated.
The boost quest progress calculation is correctly implemented
The implementation is verified to be working as intended:
relevantBoostscorrectly filters boosts that are either:
- Not expired (
b.expiry > Date.now()) OR- Have at least one completed quest (
b.quests.some((quest) => completedQuestIds.includes(quest)))completedBoostNumberaccurately counts completed boosts usingcompletedBoostIds- The progress display logic properly handles both singular/plural cases and shows completion status
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the boost filtering logic to ensure correct progress calculation # Test 1: Check if relevantBoosts filtering considers both expiry and completed quests ast-grep --pattern 'const relevantBoosts = boosts.filter((b) => { $$$ })' # Test 2: Check how completedBoostNumber is calculated ast-grep --pattern 'const completedBoostNumber = $$$' # Test 3: Look for any other progress calculations that might need updating rg -l "boost.*progress|progress.*boost" --type ts --type tsxLength of output: 995
Script:
#!/bin/bash # Let's try different patterns to find the relevantBoosts implementation # Look for relevantBoosts definition with broader pattern ast-grep --pattern 'const relevantBoosts = $_' # Search for filter conditions related to boosts rg "boosts?.filter" --type ts # Look for any boost expiry related logic rg "boost.*expir|expir.*boost" --type tsLength of output: 2057
|
@fricoben pls review |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@fricoben thanks
|
Fix Boost Quest Information Display
Fixes Issue #889
Summary
This pull request addresses the issue where boost quest information is displayed incorrectly. The boost quest currently shows
13/13even if only 3 quests are completed, which can be confusing. The following changes were made:If all quests are completed (
done_quest / total_boosted_quest = 1), the display now shows:"All quests were done"
If not all quests are completed, the display shows the correct progress:
"3/13" instead of "13/13".
Fixes
This PR fixes the issue #889, improving clarity in boost quest progress display for better user experience.
Summary by CodeRabbit
New Features
Bug Fixes