Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: new connect button #246

Merged
merged 6 commits into from
Oct 19, 2023
Merged

feat: new connect button #246

merged 6 commits into from
Oct 19, 2023

Conversation

Marchand-Nicolas
Copy link
Collaborator

close: #228

@vercel
Copy link

vercel bot commented Oct 14, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
goerli-starknet-quest ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 19, 2023 2:21am
starknet-quest ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 19, 2023 2:21am

@Marchand-Nicolas Marchand-Nicolas added the 🔥 Ready for review This pull request needs a review label Oct 14, 2023
fricoben
fricoben requested changes Oct 15, 2023
View reviewed changes
Copy link
Contributor

@fricoben fricoben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some questions and remarks.

We'll need @Kevils approval also on this one :)

components/UI/avatar.tsx Outdated Show resolved Hide resolved
components/navbar/walletButton.tsx Show resolved Hide resolved
@fricoben fricoben added ❌ Change request Change requested from reviewer and removed 🔥 Ready for review This pull request needs a review labels Oct 15, 2023
@Marchand-Nicolas Marchand-Nicolas added 🔥 Ready for review This pull request needs a review and removed ❌ Change request Change requested from reviewer labels Oct 16, 2023
fricoben
fricoben requested changes Oct 18, 2023
View reviewed changes
Copy link
Contributor

@fricoben fricoben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All code is good. Here are some front-end problems after testing everything.

https://www.loom.com/share/a2d9ac1ec5414e32852d1439ee91e9c1

@fricoben fricoben added ❌ Change request Change requested from reviewer and removed 🔥 Ready for review This pull request needs a review labels Oct 18, 2023
@Marchand-Nicolas Marchand-Nicolas added 🔥 Ready for review This pull request needs a review and removed ❌ Change request Change requested from reviewer labels Oct 18, 2023
fricoben
fricoben approved these changes Oct 19, 2023
View reviewed changes
Copy link
Contributor

@fricoben fricoben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@fricoben fricoben merged commit cac5c07 into testnet Oct 19, 2023
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fricoben fricoben fricoben approved these changes

Assignees
No one assigned
Labels
🔥 Ready for review This pull request needs a review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

New button connect with dropdown
2 participants
@Marchand-Nicolas @fricoben