Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: change responsive navbar like on starknet.id #164

Merged
merged 3 commits into from
Sep 23, 2023
Merged

feat: change responsive navbar like on starknet.id #164

merged 3 commits into from
Sep 23, 2023

Conversation

Marchand-Nicolas
Copy link
Collaborator

@Marchand-Nicolas Marchand-Nicolas commented Sep 23, 2023 •
edited
Loading

close: #149

@vercel
Copy link

vercel bot commented Sep 23, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
goerli-starknet-quest ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 23, 2023 2:12pm
starknet-quest ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 23, 2023 2:12pm

fricoben
fricoben requested changes Sep 23, 2023
View reviewed changes
Copy link
Contributor

@fricoben fricoben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wrong link but the rest is good thx !

components/UI/navbar.tsx Outdated
<div className="flex">
<div className="rounded-full shadow-gray-400 p-3 cursor-pointer hover:scale-105 ease-in duration-300 mt-2">
<a
href="https://twitter.com/Starknet_id"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wrong link :) (starknet_quest)

fricoben
fricoben approved these changes Sep 23, 2023
View reviewed changes
Copy link
Contributor

@fricoben fricoben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@fricoben fricoben merged commit 5d48305 into testnet Sep 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fricoben fricoben fricoben approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Change responsive navbar like on Starknet ID
2 participants
@Marchand-Nicolas @fricoben