Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: new quest page #153
feat: new quest page #153
Changes from 5 commits
b321b82
76949d6
887bc2c
0d67a7a
dce50cf
0cc007f
b4b43b0
633331b
7dbaafc
d8f4eb5
f4645f2
8c8467f
d05f0ad
6cb5452
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This logic has to be on the back end directly imo :)
It means the query would give you directly what you need instead of having to do all of this. That's why I wanted us to talk to guide you on the back-end part.
Should be pretty easy to do tho you already did 90% of the work.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here we would have the Trendings quests directly in the database instead of taking the first 6.
We'll need to ask thomas this :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A mon avis le naming du composant est pas bon parce qu'il évoque pas le fait que ce soit que les NFTs des catégories
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
En fait j'ai décomposé le composant Nft Display en deux composants, car à des endroits on a besoins seulement de la partie NftIssuer, d'autres endroits seulements la partie Nfts, et encore d'autres où ce sont les deux dont ont a besoins.
Du coup ça fait que le composant Nfts n'est pas utilisé que par les catégories, mais aussi par d'autres :
Par contre je suis preneurs pour un meilleur naming
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Merci de l'explication
nftImage
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"s" : null
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Peux tu expliquer cela ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Je cache la scroll bar quand le composant est load (quand la catégorie est affichée à l'écran), et quand il est unload (que je clique sur "back") je réaffiche la scroll bar de la page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
En général j'essaye d'éviter ce genre de chose, peux tu m'expliquer comment ça rend dans le front je ne vois pas ou c'est
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
C'est quand on clique sur une catégorie :
C'est ce qui l'affiche à l'écran.
Tu penses que ce serait plus propre de faire quelque chose du genre
onClick={() => setSelectedIndex(index ) }
?