Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add land #139

Merged
merged 55 commits into from
Sep 14, 2023
Merged

feat: add land #139

merged 55 commits into from
Sep 14, 2023

Conversation

irisdv
Copy link
Collaborator

@irisdv irisdv commented Aug 30, 2023 •
edited
Loading

Closes #128
and closes #127
and closes #137

@vercel
Copy link

vercel bot commented Aug 30, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
goerli-starknet-quest ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 14, 2023 8:05am
starknet-quest ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 14, 2023 8:05am

fricoben
fricoben requested changes Sep 13, 2023
View reviewed changes
Copy link
Contributor

@fricoben fricoben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some final comments

components/UI/profileCard.tsx Show resolved Hide resolved
components/lands/buildingTooltip.tsx Outdated Show resolved Hide resolved
components/lands/buildings.tsx Outdated Show resolved Hide resolved
components/lands/roadProps.tsx Outdated Show resolved Hide resolved
fricoben
fricoben approved these changes Sep 14, 2023
View reviewed changes
Copy link
Contributor

@fricoben fricoben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A small approve for the man

A big leap for Iris !

Trop cool bien joué !

@fricoben fricoben merged commit c59dcb9 into testnet Sep 14, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fricoben fricoben fricoben approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add a footer with infos Move lands to starknet Quest website Add profile to starknet lands
2 participants
@irisdv @fricoben