Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ref: update uri management & include sliced domain in offchain_resolver error msg #4

Merged
merged 1 commit into from
Apr 17, 2024
Merged

ref: update uri management & include sliced domain in offchain_resolver error msg #4

merged 1 commit into from
Apr 17, 2024

Conversation

irisdv
Copy link
Collaborator

@irisdv irisdv commented Apr 17, 2024

This PR :

  • updates how we handle uri & the event we fire on modification, you can now store multiple uris
  • updates the offchain_resolver error message to also include the sliced domain, followed by the list of uri.

@irisdv irisdv requested a review from Th0rgal April 17, 2024 14:14
@irisdv irisdv added the 🔥 Ready for review This pull request needs a review label Apr 17, 2024
Th0rgal
Th0rgal approved these changes Apr 17, 2024
View reviewed changes
Copy link
Member

@Th0rgal Th0rgal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

super cool

@Th0rgal Th0rgal merged commit 8a51512 into master Apr 17, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Th0rgal Th0rgal Th0rgal approved these changes

Assignees
No one assigned
Labels
🔥 Ready for review This pull request needs a review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@irisdv @Th0rgal