Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add StarknetIDOffChainResolverUpdate event & update_uri function #3

Merged
merged 3 commits into from
Apr 15, 2024
Merged

feat: add StarknetIDOffChainResolverUpdate event & update_uri function #3

merged 3 commits into from
Apr 15, 2024

Conversation

irisdv
Copy link
Collaborator

@irisdv irisdv commented Apr 11, 2024

Part of lfglabs-dev/api.starknet.id#72

This PR adds ownable component, a new update_uri function & a StarknetIDOffChainResolverUpdate event fired on deployment and on update_uri, that we will index.

@irisdv irisdv requested a review from Th0rgal April 11, 2024 13:08
@irisdv irisdv added the 🔥 Ready for review This pull request needs a review label Apr 11, 2024
Th0rgal
Th0rgal approved these changes Apr 15, 2024
View reviewed changes
Copy link
Member

@Th0rgal Th0rgal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Th0rgal Th0rgal merged commit 83baad5 into master Apr 15, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Th0rgal Th0rgal Th0rgal approved these changes

Assignees
No one assigned
Labels
🔥 Ready for review This pull request needs a review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@irisdv @Th0rgal