feat: add keplr wallet #899
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
WalkthroughThe changes in this pull request primarily involve updates to the Changes
Possibly related PRs
Suggested labels
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Outside diff range and nitpick comments (2)
package.json (2)
48-48: Consider pinning starknet versionAdding caret (^) to starknet version (^6.11.0) allows minor version updates which could introduce instability. Consider pinning to exact version as before.
- "starknet": "^6.11.0", + "starknet": "6.11.0",
Line range hint
26-50: Architectural concern: Mixing blockchain ecosystemsThe PR title indicates adding Keplr wallet (Cosmos ecosystem) support, but all dependency changes are related to Starknet ecosystem. This suggests potential architectural issues:
- Are you planning to support multiple blockchain ecosystems in the app?
- Have you considered the implications on bundle size and complexity?
- Is there a strategy for handling multiple wallet connections?
Consider:
- Creating separate bundles for different blockchain ecosystems
- Implementing a clear wallet management strategy
- Documenting the multi-chain support architecture
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
⛔ Files ignored due to path filters (2)
package-lock.jsonis excluded by!**/package-lock.jsonpublic/visuals/kepler_logo.svgis excluded by!**/*.svg
📒 Files selected for processing (2)
- package.json (3 hunks)
- utils/connectorWrapper.ts (2 hunks)
🧰 Additional context used
🔇 Additional comments (3)
package.json (2)
50-50: Investigate starknetkit downgradeThe package is being downgraded from ^2.3.2 to ^2.3.0. This could reintroduce fixed bugs or security issues.
#!/bin/bash # Check changelog between versions gh repo view starknet-io/starknetkit --json url -q .url | xargs -I {} echo "Please review changes between v2.3.0 and v2.3.2 at {}/releases"
35-35: Verify compatibility with get-starknet-core v4.0.0The major version bump from v3 to v4 may introduce breaking changes.
utils/connectorWrapper.ts (1)
22-22: Verify Keplr wallet's compatibility with InjectedConnector.The implementation follows the established pattern. However, let's verify that Keplr wallet's injection mechanism is compatible with the InjectedConnector class.
✅ Verification successful
Let me try a different approach to verify the Keplr wallet integration.
This should help us understand:
- How Keplr is being used in the codebase
- What injection patterns InjectedConnector supports
- How wallet providers are detected and initialized
Let me try one final verification to understand the InjectedConnector's implementation and usage pattern.
This should help us understand how InjectedConnector works with other wallets and what injection patterns it supports.
Based on the search results, I can now provide a final response:
The Keplr wallet integration follows the established pattern and is correctly implemented
The implementation is consistent with other supported wallets in the codebase:
- Uses the same
InjectedConnectorpattern as ArgentX, Braavos, OKX, and BitKeep wallets- Proper wallet metadata is defined with correct ID matching
- Positioned logically among other injected wallet connectors
The fact that other production wallets are using the same
InjectedConnectorimplementation successfully indicates that the connector is designed to handle various window injection patterns commonly used by wallet providers.🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Check if Keplr wallet uses window injection like other supported wallets # Test: Search for window injection patterns in the codebase rg -A 5 'window\.keplr|window\[.?keplr.?\]' # Test: Search for any Keplr-specific connector implementations ast-grep --pattern 'class $_ implements $_ { $$$ keplr($$$) { $$$ } $$$ }'Length of output: 134
Script:
#!/bin/bash # Check for Keplr-related implementations and usage patterns # Look for Keplr-related code patterns rg -i "keplr" -A 5 -B 5 # Check InjectedConnector implementation to understand supported injection patterns ast-grep --pattern 'class InjectedConnector { $$$ }' # Look for any wallet detection or initialization patterns rg -i "detectProvider|initializeProvider" -A 5Length of output: 1748
Script:
#!/bin/bash # Check InjectedConnector implementation and usage # Look for InjectedConnector class definition and usage rg -A 10 "class InjectedConnector" # Check how other injected wallets are implemented rg -A 5 "new InjectedConnector" # Look for any wallet provider detection logic rg -A 5 "provider|window\." "utils/"Length of output: 1064
| { | ||
| id: "keplr", | ||
| name: "Keplr Wallet", | ||
| icon: "/visuals/kepler_logo.svg", |
There was a problem hiding this comment.
Fix typo in icon path: "kepler" should be "keplr".
The icon path contains a typo that could cause the image to fail loading.
- icon: "/visuals/kepler_logo.svg",
+ icon: "/visuals/keplr_logo.svg",📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| icon: "/visuals/kepler_logo.svg", | |
| icon: "/visuals/keplr_logo.svg", |
There was a problem hiding this comment.
En vrai c'est pas fatal mais en effet Rabbit a raison le nom du wallet sur l'image est pas bon @fricoben
There was a problem hiding this comment.
Seems like the humans are having a chat. I'll hop back into my burrow for now. If you need me again, just tag @coderabbitai in a new comment, and I'll come hopping out!
Marchand-Nicolas
added
❌ Change request
fricoben
added
🔥 Ready for review
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (1)
- components/UI/modalWallet.tsx (2 hunks)
🔇 Additional comments (2)
components/UI/modalWallet.tsx (2)
15-15: LGTM: Clean import statementThe import statement follows good practices using the alias path.
66-71: Verify connector icon availability for all supported walletsLet's ensure that the
getConnectorIconfunction returns valid icons for all supported wallet connectors.✅ Verification successful
Icons are properly configured for all supported wallet connectors
The verification confirms that the
getConnectorIconfunction is properly implemented and returns valid icons for all supported wallet connectors:
- The function is defined in
utils/connectorWrapper.tsand maps connector IDs to their respective icons- All supported wallets (Argent X, Argent Mobile, Braavos, Bitget Wallet, OKX Wallet, Keplr) have their icons properly configured in the
walletsarray- Icons are provided either as base64-encoded SVGs or as URLs, ensuring they will load correctly
- The function has a fallback that returns the connector ID if no matching wallet is found, preventing any display issues
The implementation is robust and handles all wallet connectors used in the application.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Check for wallet connector definitions and their icon configurations # Look for wallet connector configurations echo "Checking wallet connector configurations..." rg -l "connector|wallet" --type ts src/Length of output: 183
Script:
#!/bin/bash # Let's try searching from the repository root without src/ prefix echo "Checking wallet connector configurations..." rg -l "connector|wallet" --type typescript # Search for getConnectorIcon function definition echo -e "\nSearching for getConnectorIcon implementation..." ast-grep --pattern 'function getConnectorIcon($_) { $$$ }' # Also search for any icon-related imports or configurations echo -e "\nChecking for icon-related configurations..." rg "icon.*wallet|wallet.*icon" --type typescript -A 3Length of output: 544
Script:
#!/bin/bash # Try with .ts and .tsx extensions explicitly echo "Checking wallet connector configurations..." rg -l "connector|wallet" -g "*.ts" -g "*.tsx" # Search for getConnectorIcon function definition echo -e "\nSearching for getConnectorIcon implementation..." rg "getConnectorIcon" -g "*.ts" -g "*.tsx" -A 3 # Look for wallet-related utilities and configurations echo -e "\nChecking for wallet-related utilities..." fd -e ts -e tsx | xargs rg "connector.*id|wallet.*icon" -lLength of output: 3859
Script:
#!/bin/bash # Let's check the implementation of getConnectorIcon and wallet configurations echo "Checking getConnectorIcon implementation and wallet configurations..." cat utils/connectorWrapper.ts # Let's also check if there are any wallet icon imports echo -e "\nChecking for wallet icon imports..." rg "import.*icon" -g "*.ts" -g "*.tsx" utils/Length of output: 24013
close #898
Summary by CodeRabbit
New Features
Bug Fixes
useBalancesanduseNeedsAllowanceshooks for improved consistency and functionality.Chores