fix: failing to fetch deployment data

[Marchand-Nicolas]

Summary by CodeRabbit

• New Features

  • Enhanced deployment data fetching without requiring wallet connection status (except for specific IDs).
  • Improved error handling for deployment data fetching.

• Chores

  • Updated the version of the @avnu/gasless-sdk dependency.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
app-starknet-id	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Oct 11, 2024 9:40am
sepolia-app-starknet-id	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Oct 11, 2024 9:40am

[coderabbitai]

Walkthrough

The pull request modifies the isStarknetDeployed function in hooks/isDeployed.tsx to allow fetching deployment data without checking the wallet's connection status, provided the wallet ID matches the connector's ID and is not "braavos." Enhanced error handling has been added to the checkIsDeployed function for better logging of errors. Additionally, the package.json file is updated to change the version of the @avnu/gasless-sdk dependency from ^0.1.2 to ^0.1.6.

Changes

File	Change Summary
hooks/isDeployed.tsx	Modified isStarknetDeployed to remove the wallet connection check; enhanced error handling in checkIsDeployed.
package.json	Updated @avnu/gasless-sdk version from ^0.1.2 to ^0.1.6.

Possibly related PRs

• fix: web wallet connection #893: The changes in the package.json file regarding dependency updates may be related as both PRs involve modifications to the package.json for the starknet-id-app project, although they address different dependencies.

Suggested reviewers

• fricoben

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between 4d6628c and 1f18ca6.

⛔ Files ignored due to path filters (1)

• package-lock.json is excluded by !**/package-lock.json

📒 Files selected for processing (2)

• hooks/isDeployed.tsx (0 hunks)
• package.json (1 hunks)

💤 Files with no reviewable changes (1)

• hooks/isDeployed.tsx

🧰 Additional context used

🔇 Additional comments (1)

package.json (1)

14-14: Approve the dependency update, but request additional information.

The update of @avnu/gasless-sdk from ^0.1.2 to ^0.1.6 looks good. However, to ensure this change aligns with the PR objectives and doesn't introduce any unintended consequences, please provide some additional context:

1. Is this update directly related to fixing the issue of "failing to fetch deployment data" as mentioned in the PR title?
2. Have you reviewed the changelog for @avnu/gasless-sdk between versions 0.1.2 and 0.1.6 to ensure there are no breaking changes that might affect the project?

To help verify the impact of this change, please run the following script:

This script will fetch the changelog from the @avnu/gasless-sdk repository and search for any mentions of breaking changes or major updates. Please review the output to ensure that the update is safe to proceed with.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[fricoben]

lgtm