ref: free renewal adaptation

[fricoben]

Summary by CodeRabbit

• New Features

  • Introduced a custom hook for preparing transaction calls for free domain renewals, enhancing efficiency and clarity.

• Bug Fixes

  • Updated the expiry date for the free renewal discount, now expiring on September 25, 2024.

• Refactor

  • Streamlined the pricing logic in the FreeRenewalCheckout component for better handling of multiple currencies.

• Chores

  • Cleaned up unused code and variables to improve maintainability.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
app-starknet-id	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Sep 16, 2024 6:03pm
sepolia-app-starknet-id	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Sep 16, 2024 6:03pm

[coderabbitai]

Walkthrough

The pull request introduces significant refactoring in the FreeRenewalCheckout component, enhancing the handling of pricing and transaction calls for free renewals. It introduces a new custom hook, useFreeRenewalTxPrep, to streamline transaction preparation by consolidating logic related to pricing and allowances. Additionally, minor adjustments are made in the Identity class and the freeRenewalDiscount object to improve code clarity and update the discount's expiry date.

Changes

File Path	Change Summary
components/discount/freeRenewalCheckout.tsx	Refactored pricing logic; introduced useFreeRenewalTxPrep hook for transaction calls; replaced single potentialPrice with potentialPrices object for better currency handling; removed unused variables.
hooks/checkout/useFreeRenewalTxPrep.tsx	Added a custom hook to prepare transaction calls for free renewals, managing state and constructing calls based on various parameters.
utils/apiWrappers/identity.ts	Changed variable declarations in targetAddress from let to const for clarity.
utils/discounts/freeRenewal.ts	Updated expiry timestamp in freeRenewalDiscount object to a new date, altering the discount's validity period.

Possibly related PRs

• fix: feedback free renewal #790: Modifications in FreeRenewalDiscount regarding the handling of potentialPrice and the introduction of getTotalYearlyPrice, which relate to the refactoring of pricing logic in the main PR.
• fix: coupon errors #875: Updates in FreeRegisterCheckout to manage loading states and simplify coupon validation logic align with the changes made in the main PR to enhance user experience and streamline functionality.

Suggested labels

🔥 Ready for review

---

Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 5f7548f and 0b20a4c.

Files selected for processing (1)

• hooks/checkout/useFreeRenewalTxPrep.tsx (1 hunks)

Files skipped from review as they are similar to previous changes (1)

• hooks/checkout/useFreeRenewalTxPrep.tsx

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  -- I pushed a fix in commit <commit_id>, please review it.
  -- Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  -- @coderabbitai generate unit testing code for this file.
  -- @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  -- @coderabbitai generate interesting stats about this repository and render them as a table.
  -- @coderabbitai read src/utils.ts and generate unit testing code.
  -- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  -- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 2

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 3cf64b3 and ddf39fe.

Files selected for processing (4)

• components/discount/freeRenewalCheckout.tsx (6 hunks)
• hooks/checkout/useFreeRenewalTxPrep.tsx (1 hunks)
• utils/apiWrappers/identity.ts (1 hunks)
• utils/discounts/freeRenewal.ts (1 hunks)

Files skipped from review due to trivial changes (1)

• utils/apiWrappers/identity.ts

Additional comments not posted (13)

utils/discounts/freeRenewal.ts (1)

13-13: LGTM!

The update to the expiry timestamp is straightforward and does not introduce any issues. The change is consistent with the AI-generated summary and alters the validity period of the discount to expire on September 25, 2024, at 23:59:59.

hooks/checkout/useFreeRenewalTxPrep.tsx (1)

1-21: LGTM!

The imports are well-organized and only the necessary modules are being imported.

components/discount/freeRenewalCheckout.tsx (11)

5-5: LGTM!

The import statement is correct and necessary for the component.

---

31-31: LGTM!

The import statement is correct and necessary for the component.

---

33-33: LGTM!

The import statement is correct and necessary for the component.

---

61-66: LGTM!

The state variable declaration for potentialPrices is correct and necessary for managing potential prices in the component.

---

73-82: LGTM!

The usage of the useFreeRenewalTxPrep custom hook is correct and helps streamline the transaction preparation logic. The parameters passed to the hook are relevant and necessary for preparing the transaction calls.

---

232-234: LGTM!

The logic for setting the salesTaxAmount based on the potentialPrices and swissVatRate is correct and uses the appropriate utility function.

---

239-239: LGTM!

Including potentialPrices as a dependency in the useEffect hook is correct and ensures that the effect is triggered when the potential prices change.

---

248-263: LGTM!

The logic for calculating new potential prices based on the displayedCurrencies, selectedDomains, and quoteData is correct and uses the appropriate utility function. Updating the potentialPrices state variable by merging the previous prices with the new potential prices ensures that the state is updated correctly.

---

269-269: LGTM!

The logic for setting the customCheckoutMessage using the newPotentialPrices object is correct and handles the case when the price for the potential currency is not available.

---

320-320: LGTM!

Passing the potentialPrices[CurrencyType.ETH] as the priceInEth prop to the RegisterSummary component is correct and provides the price in ETH to the component.

---

Line range hint 1-375: Excellent refactoring work!

The changes in this file significantly improve the handling of pricing and transaction calls for free renewals. The introduction of the useFreeRenewalTxPrep custom hook is a great way to streamline the transaction preparation logic and consolidate related functionality.

The transition from a single potentialPrice variable to a structured potentialPrices object enhances the state management for potential prices and allows for better handling of multiple currencies.

The code cleanup efforts, such as removing unused imports, state variables, and commented-out sections, contribute to improved code clarity and maintainability.

Overall, the refactoring aligns well with the PR objectives and the AI-generated summary. Great job!

[irisdv]

There are some conflicts.
Also I can't test the free renewal on sepolia, I get this error when I try : Tx not executed:Ar not whitelisted