-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add twitter cards #863
Conversation
WalkthroughThe updates enhance the metadata in the Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- pages/_document.tsx (1 hunks)
Additional comments not posted (6)
pages/_document.tsx (6)
12-12
: LGTM!The update to the
og:title
meta tag aligns with the branding strategy.
16-16
: LGTM!The update to the
og:description
meta tag improves clarity and effectiveness.
22-22
: LGTM!The update to the
description
meta tag ensures consistency across meta tags.
25-25
: LGTM!The update to the
twitter:title
meta tag aligns with the branding strategy.
28-28
: LGTM!The update to the
twitter:description
meta tag improves clarity and effectiveness.
31-38
: LGTM!The new meta tags for
twitter:card
,twitter:player
, and player dimensions enhance the way content is shared on Twitter, potentially improving user engagement.
387be35
to
af302a0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- pages/_document.tsx (1 hunks)
Files skipped from review as they are similar to previous changes (1)
- pages/_document.tsx
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Adding cards like so https://github.com/keep-starknet-strange/awesome-slinks?tab=readme-ov-file#how-to-implement-a-slink
Summary by CodeRabbit
New Features
Improvements