feat: handle analytics data after expiry #202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ayushtom
added
the
🚧 In progress do not merge
ayushtom
force-pushed
the
ayush/handle-expiry-data
branch
from
f2211a5 to
25bc1ed
Compare
ayushtom
force-pushed
the
ayush/handle-expiry-data
branch
from
25bc1ed to
95a7192
Compare
ayushtom
added
🔥 Ready for review
Th0rgal
requested changes
Apr 23, 2024
| )] | ||
| pub async fn handler( | ||
| State(state): State<Arc<AppState>>, | ||
| Query(query): Query<GetQuestsQuery>, | ||
| ) -> impl IntoResponse { | ||
| let current_time = chrono::Utc::now().timestamp_millis(); |
There was a problem hiding this comment.
I personally make it miliseconds to make it precise in all cases. Not that it's very relevant for our usecase but i followed this convention in other endpoints like tasks and boosts too.Do you think i should change this to seconds?
Th0rgal
added
❌ Change request
|
Probabyl doesn't require a change but just an explanation :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to stop using data for analytics for tasks completion of the quest once the quest has expired. This data is irrelevant and we would need to remove it from the stats dashboard.
We also modify the document model for to add some kind of automation on quests -
https://www.notion.so/lfg-labs/Quest-DB-Update-6a216557a4084a60a5cd744f07c8a92a?pvs=4