Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add carbonable #192

Merged
merged 5 commits into from
Feb 27, 2024
Merged

feat: add carbonable #192

merged 5 commits into from
Feb 27, 2024

Conversation

ayushtom
Copy link
Contributor

@ayushtom ayushtom commented Feb 27, 2024

Performs the following tasks

  • check domain
  • check twitter follow braavos
  • check carbonable follow twitter
  • check retweet
  • check deposit

@ayushtom ayushtom marked this pull request as ready for review February 27, 2024 14:37
@ayushtom ayushtom self-assigned this Feb 27, 2024
@ayushtom ayushtom added the 🔥 Ready for review This pull request needs a review label Feb 27, 2024
@ayushtom ayushtom requested a review from Th0rgal February 27, 2024 14:40
Copy link
Collaborator

@irisdv irisdv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small issue with task_id I think, other than that lgtm

State(state): State<Arc<AppState>>,
Query(query): Query<VerifyQuery>,
) -> impl IntoResponse {
let task_id = 131;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

on notion it says that task_id 131 is retweet the quest thread and 130 should be this one

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@irisdv irisdv added ❌ Change request Change requested from reviewer and removed 🔥 Ready for review This pull request needs a review labels Feb 27, 2024
@ayushtom ayushtom requested a review from irisdv February 27, 2024 15:50
@ayushtom ayushtom added 🔥 Ready for review This pull request needs a review and removed ❌ Change request Change requested from reviewer labels Feb 27, 2024
Copy link
Collaborator

@irisdv irisdv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@irisdv irisdv merged commit 3381098 into master Feb 27, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔥 Ready for review This pull request needs a review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants