Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Language and diagram server built using Gradle #85

Merged
merged 3 commits into from
Nov 15, 2022
Merged

Conversation

a-sr
Copy link
Contributor

@a-sr a-sr commented Nov 11, 2022

Requires PR #1469 in LF
Uses the new Gradle build built the LDS jar.
Special handling of SWT library is no longer necessary and removed.

@a-sr a-sr added the build label Nov 11, 2022
@a-sr a-sr marked this pull request as ready for review November 11, 2022 15:34
@a-sr a-sr requested a review from lhstrh November 11, 2022 15:34
@a-sr
Copy link
Contributor Author

a-sr commented Nov 11, 2022

@lhstrh I updated the LF submodule. I don't know if there is a coordinated process for updating it or if it is fine this way.

I also added support for launching the extension with a language server connected via socket. I only tested it in Eclipse. I don't know how it will work in IntelliJ but you need to start/debug the project via the main class org.lflang.diagram.lsp.LanguageDiagramServer with the VM option -Dport=7670, while starting the extension with the Launch Extension (Socket) configuration.

Copy link
Member

@lhstrh lhstrh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, with exception of the version number issue I pointed out.

src/config.ts Show resolved Hide resolved
@lhstrh lhstrh requested a review from petervdonovan November 14, 2022 23:52
@lhstrh lhstrh merged commit e017a11 into main Nov 15, 2022
@lhstrh lhstrh deleted the lds-gradle-build branch November 15, 2022 19:34
@lhstrh lhstrh changed the title Switched to Gradle for language and diagram server build Language and diagram server built using Gradle Feb 27, 2023
@lhstrh lhstrh added the enhancement New feature or request label Feb 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants